Re: ntdll: Fix the file mapping view leak in the case of module loading failure. Take 2.

2012-02-27 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> I don't see any evidence that you are addressing the issues that caused >> us to not do that in the first place. > > Because the only thing I want to see fixed at this point is a view leak, > it's still better than current state of things

Re: ntdll: Fix the file mapping view leak in the case of module loading failure. Take 2.

2012-02-27 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > I don't see any evidence that you are addressing the issues that caused > us to not do that in the first place. Because the only thing I want to see fixed at this point is a view leak, it's still better than current state of things. Without this fix Wine shows exactl

Re: ntdll: Fix the file mapping view leak in the case of module loading failure. Take 2.

2012-02-27 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -1548,6 +1549,11 @@ static NTSTATUS load_native_dll( LPCWSTR load_path, > LPCWSTR name, HANDLE file, > *pwm = wm; > status = STATUS_SUCCESS; > done: > +if (status) > +{ > +if (wm) free_modref( wm ); > +else if (module) NtUnmapViewO