Re: ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2

2006-08-02 Thread Mike McCormack
Dan Kegel wrote: No fair, Mike, you should have given the link to the PR: http://gcc.gnu.org/PR19430 :) If you know a gcc person that has time, nagging them would be great. Many similar errors will get caught, as long as you turn on the optimizer with -O (otherwise the compiler can't detect

Re: ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2

2006-08-02 Thread Dan Kegel
On 8/2/06, Mike McCormack <[EMAIL PROTECTED]> wrote: > ["void *foo" is better than "void *foo = NULL", you want it > to remain uninitialized because that way the compiler will warn] gcc version 4.1.2 20060729 (prerelease) (Debian 4.1.1-10) [EMAIL PROTECTED]:~/wine$ cat foobar.c void foo(int *);

Re: ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2

2006-08-02 Thread Mike McCormack
Mike Hearn wrote: And there are a few small style nits, for instance there's usually no reason to change "void *foo" to "void *foo = NULL", you want it to remain uninitialized because that way the compiler will warn if it's ever used before being set to something: superior to blindly using a NU

Re: ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2

2006-08-02 Thread Mike Hearn
On 8/3/06, Dan Kegel <[EMAIL PROTECTED]> wrote: The goal is to get rid of the service thread; the service thread was just there as a placeholder. Once it's gone, signals are appropriate. The realtime signal is just there as a placeholder until we figure out how to squeze this down into SIGUSR1 a

Re: ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2

2006-08-02 Thread Dan Kegel
On 8/2/06, Mike Hearn <[EMAIL PROTECTED]> wrote: - The service thread seems like a good idea to me. But why use a signal in this case, when there are simpler ways to achieve the same thing, for instance with a named pipe? - I'm not sure using the realtime signals will work. I don't remem

Re: ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2

2006-08-02 Thread Mike Hearn
On Tue, 01 Aug 2006 20:41:54 -0500, Thomas Kho wrote: > This is an implementation of CreateRemoteThread and RtlCreateUserThread for > remote processes that re-introduces a service thread for each process and uses > a signal to flag pending operations. Operations are guarded by a global mutex > for

ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2

2006-08-01 Thread Thomas Kho
ntdll: CreateRemoteThread and RtlCreateUserThread for remote processes, take 2 Hello, This is an implementation of CreateRemoteThread and RtlCreateUserThread for remote processes that re-introduces a service thread for each process and uses a signal to flag pending operations. Operations are