Re: ntdll: Add a file access test.

2013-09-13 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Nikolay Sivov wrote: > >> >> It looks like it belongs to kernel32/tests. >> > Since actual access checks are done by ntdll APIs I believe that >> > ntdll/tests >> > is appropriate place, kernel32 file APIs are just wrappers around the >> > tested >> > functionality.

Re: ntdll: Add a file access test.

2013-09-13 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > >> It looks like it belongs to kernel32/tests. > > Since actual access checks are done by ntdll APIs I believe that ntdll/tests > > is appropriate place, kernel32 file APIs are just wrappers around the tested > > functionality. > > > It doesn't matter what it uses internall

Re: ntdll: Add a file access test.

2013-09-13 Thread Nikolay Sivov
On 9/13/2013 12:16, Dmitry Timoshkov wrote: Nikolay Sivov wrote: It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. It doesn't ma

Re: ntdll: Add a file access test.

2013-09-13 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. -- Dmitry.

Re: ntdll: Add a file access test.

2013-09-13 Thread Nikolay Sivov
On 9/13/2013 11:20, Dmitry Timoshkov wrote: This test passes under Wine and shows that ReadFile after CreateFile(GENERIC_WRITE) is really supposed to fail. --- dlls/ntdll/tests/file.c | 82 + 1 file changed, 82 insertions(+) It looks like it b