Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-31 Thread Michael Karcher
Am Mittwoch, den 27.08.2008, 17:14 +0900 schrieb Dmitry Timoshkov: > "Markus Hitter" <[EMAIL PROTECTED]> wrote: > > > Providing the file handle allows to map > > read/write requests to the corresponding file name. > As pointed out by Alexander, you can use an appropriate debug > channel for that,

Re: ntdll/file.c: Allow to TRACE NtCreateFile return [repost]

2008-08-30 Thread Michael Karcher
Am Samstag, den 30.08.2008, 11:41 -0600 schrieb Vitaliy Margolen: > Almost no programs are calling the Nt* functions directly. But kernel32 > functions. So the point about knowing the file handle in return from > NtCreateFile is moot. And kernel32's CreateFile() already prints that > information fo

Re: ntdll/file.c: Allow to TRACE NtCreateFile return [repost]

2008-08-30 Thread Vitaliy Margolen
Michael Karcher wrote: > [The original mail seemed to be stuck in the moderation queue or > got lost somewhere else. Reposting with correct "From:" this > time] > > Am Mittwoch, den 27.08.2008, 17:14 +0900 schrieb Dmitry Timoshkov: >> "Markus Hitter" <[EMAIL PROTECTED]> wrote: >> >>> Providing the

Re: ntdll/file.c: Allow to TRACE NtCreateFile return [repost]

2008-08-30 Thread Michael Karcher
[The original mail seemed to be stuck in the moderation queue or got lost somewhere else. Reposting with correct "From:" this time] Am Mittwoch, den 27.08.2008, 17:14 +0900 schrieb Dmitry Timoshkov: > "Markus Hitter" <[EMAIL PROTECTED]> wrote: > > > Providing the file handle allows to map > > rea

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Dmitry Timoshkov
"Markus Hitter" <[EMAIL PROTECTED]> wrote: >> We all are in the same boat. It seems you didn't get the message. > Next time, please try to speak up earlier and more clearly. Four > reviews, three patch reworks were done and about 20 messages were > written, just to find out _any_ change is n

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Markus Hitter
Am 27.08.2008 um 11:40 schrieb Dmitry Timoshkov: > We all are in the same boat. Next time, please try to speak up earlier and more clearly. Four reviews, three patch reworks were done and about 20 messages were written, just to find out _any_ change is not welcome. MarKus - - - - - - - -

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Dmitry Timoshkov
"Markus Hitter" <[EMAIL PROTECTED]> wrote: > If you think this way, you should get rid of all the TRACE()s in this > source file. > > For me, it makes a difference, wether I can focus on file operations > or if I have to wade through gigabyte-sized (no joke) log files. We all are in the same

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Markus Hitter
Am 27.08.2008 um 10:14 schrieb Dmitry Timoshkov: > "Markus Hitter" <[EMAIL PROTECTED]> wrote: > >> Providing the file handle allows to map >> read/write requests to the corresponding file name. > > As pointed out by Alexander, you can use an appropriate debug > channel for that, +relay or +server

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Dmitry Timoshkov
"Markus Hitter" <[EMAIL PROTECTED]> wrote: > Providing the file handle allows to map > read/write requests to the corresponding file name. As pointed out by Alexander, you can use an appropriate debug channel for that, +relay or +server. There is no need to pollute the source with additional trac