Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-16 Thread David Laight
On Thu, Feb 16, 2012 at 03:15:59AM +0300, Nikolay Sivov wrote: > >If I remember correctly, you can even process a va_list only once > >on some platforms. > We use it that way in couple of places, so it seems to work and I can't > find a proper description or part of a standard that says it's not p

Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-16 Thread Alexandre Julliard
Nikolay Sivov writes: > The problem is that vsnprintf() was called multiple times with same > va_list. Ti fix that it was necessary to get rid of some tracing bits > like macro-defined callback calls and a single function for all kinds > of error types. Actually there's no need to call vsnprintf

Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-15 Thread Nikolay Sivov
On 2/16/2012 01:28, Marcus Meissner wrote: On Thu, Feb 16, 2012 at 01:55:44AM +0300, Nikolay Sivov wrote: The problem is that vsnprintf() was called multiple times with same va_list. Ti fix that it was necessary to get rid of some tracing bits like macro-defined callback calls and a single funct

Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-15 Thread David Laight
On Wed, Feb 15, 2012 at 11:28:37PM +0100, Marcus Meissner wrote: > On Thu, Feb 16, 2012 at 01:55:44AM +0300, Nikolay Sivov wrote: > > The problem is that vsnprintf() was called multiple times with same > > va_list. Ti fix that it was necessary to get rid of some tracing > > bits like macro-defined

Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-15 Thread Marcus Meissner
On Thu, Feb 16, 2012 at 01:55:44AM +0300, Nikolay Sivov wrote: > The problem is that vsnprintf() was called multiple times with same > va_list. Ti fix that it was necessary to get rid of some tracing > bits like macro-defined callback calls and a single function for all > kinds of error types. > >