Re: msvcrt: Implement wcscat_s (try 4)

2008-03-17 Thread Alexandre Julliard
Alistair Leslie-Hughes <[EMAIL PROTECTED]> writes: > Hi, > Added missing test You should also test that you aren't overflowing the buffer. This should help you find a bug in your implementation. -- Alexandre Julliard [EMAIL PROTECTED]

Re: msvcrt: Implement wcscat_s

2008-03-14 Thread Dmitry Timoshkov
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote: >>> +@ cdecl wcscat_s(ptr long wstr) MSVCRT_wcscat_s >> >> The first parameter has type wstr. Also, please check actual >> buffer contents in the tests not just the return values. >> > Hi Dmitry, > When I wrote the wcscpy_s you asked to me chang

Re: msvcrt: Implement wcscat_s

2008-03-14 Thread Alistair Leslie-Hughes
"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > "Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote: > >> +@ cdecl wcscat_s(ptr long wstr) MSVCRT_wcscat_s > > The first parameter has type wstr. Also, please check actual > buffer contents in the tests not just the re

Re: msvcrt: Implement wcscat_s

2008-03-14 Thread Dmitry Timoshkov
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote: > +@ cdecl wcscat_s(ptr long wstr) MSVCRT_wcscat_s The first parameter has type wstr. Also, please check actual buffer contents in the tests not just the return values. -- Dmitry.