Re: msvcrt: Don't hold FILE critical section in some functions

2011-11-15 Thread Alexandre Julliard
Piotr Caban writes: > This function is not safe under Windows 7. I was testing it with > following program: > > static DWORD WINAPI block_stdin(void *arg) > { > _lock_file(stdout); > return 0; > } > > int main( ) > { > DWORD thread_id; > > CreateThread(NULL, 0, block_stdin

Re: msvcrt: Don't hold FILE critical section in some functions

2011-11-15 Thread Piotr Caban
On 11/15/11 16:34, Alexandre Julliard wrote: Piotr Caban writes: @@ -3117,25 +3098,20 @@ int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) */ int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) { -MSVCRT__lock_file(file); - /* Flush output buffer */ if(file->_bufsiz == 0&&

Re: msvcrt: Don't hold FILE critical section in some functions

2011-11-15 Thread Alexandre Julliard
Piotr Caban writes: > @@ -3117,25 +3098,20 @@ int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) > */ > int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) > { > -MSVCRT__lock_file(file); > - > /* Flush output buffer */ > if(file->_bufsiz == 0 && !(file->_flag & MSVCRT__IONBF)) { >