Re: msvcrt: Add support for sprintf_s

2010-01-11 Thread Jason Edmeades
>This doesn't seem correct to me You are right, its incomplete, but it also was based on the logic already in MSVCRT_vswprintf_s, which is just as incomplete! I'll happily just raise a bug report if the patch is insufficient, but in general all the _s special processing is missing from the printf

Re: msvcrt: Add support for sprintf_s

2010-01-11 Thread André Hentschel
Chris Robinson schrieb: > This doesn't seem correct to me. According to MSDN, sprintf_s checks for > valid > formatting chars (in addition to the buffer and format arguments) and invokes > an invalid parameter handler if something bad turns up. It then returns -1 > with errno set to EINVAL if e

Re: msvcrt: Add support for sprintf_s

2010-01-10 Thread Chris Robinson
This doesn't seem correct to me. According to MSDN, sprintf_s checks for valid formatting chars (in addition to the buffer and format arguments) and invokes an invalid parameter handler if something bad turns up. It then returns -1 with errno set to EINVAL if execution is allowed to continue. Ad