Re: msvcp90: Fix __cdecl functions definitions that returns structures

2012-07-02 Thread Alexandre Julliard
Piotr Caban writes: > I'm not sure how to write tests for these functions. I see two > possibilities in case of functions returning "big" structures > (e.g. _Getctype). Should I write a test that calls the function in a > loop to make sure the tests are crashing if it corrupts the stack? Or > may

Re: msvcp90: Fix __cdecl functions definitions that returns structures

2012-07-02 Thread Piotr Caban
On 06/29/12 19:33, Alexandre Julliard wrote: Piotr Caban writes: In code produced by gcc callee removes hidden return argument. In code produced by MS Visual Studio caller is responsible for removing the hidden argument. That's only for structures larger than 8 bytes, which isn't the case at

Re: msvcp90: Fix __cdecl functions definitions that returns structures

2012-06-29 Thread Alexandre Julliard
Piotr Caban writes: > In code produced by gcc callee removes hidden return argument. In code > produced by MS Visual Studio caller is responsible for removing the > hidden argument. That's only for structures larger than 8 bytes, which isn't the case at least for _Getcoll. Some tests would proba