Re: [PATCH] msiexec: implement a sane server stub (i.e. not while(TRUE); )

2011-08-27 Thread Bernhard Loos
On Fri, Aug 26, 2011 at 9:11 AM, Hans Leidekker wrote: > On Fri, 2011-08-26 at 04:58 +0200, Bernhard Loos wrote: > > - * Copyright 2007 Google (James Hawkins) > + * Copyright 2011 Bernhard Loos > > Please keep the original copyright information. > Well, there is basically nothing left of the orig

Re: [PATCH] msiexec: implement a sane server stub (i.e. not while(TRUE); )

2011-08-26 Thread Hans Leidekker
On Fri, 2011-08-26 at 09:32 +0200, Bernhard Loos wrote: > On Fri, Aug 26, 2011 at 9:11 AM, Hans Leidekker wrote: > > On Fri, 2011-08-26 at 04:58 +0200, Bernhard Loos wrote: > > > > - * Copyright 2007 Google (James Hawkins) > > + * Copyright 2011 Bernhard Loos > > > > Please keep the original copyr

Re: [PATCH] msiexec: implement a sane server stub (i.e. not while(TRUE); )

2011-08-26 Thread Hans Leidekker
On Fri, 2011-08-26 at 04:58 +0200, Bernhard Loos wrote: - * Copyright 2007 Google (James Hawkins) + * Copyright 2011 Bernhard Loos Please keep the original copyright information.

Re: uninstaller: Run msiexec if the WindowsInstaller value is set.

2010-12-23 Thread Alexandre Julliard
Hans Leidekker writes: > --- > programs/uninstaller/main.c | 23 +++ > 1 files changed, 19 insertions(+), 4 deletions(-) Note that appwiz.cpl will need the same change (of course uninstaller should really be calling appwiz.cpl in the first place). -- Alexandre Julliard j

Re: [PATCH] msiexec: Use resource in msi for a Help Dialog to allow translation

2010-04-21 Thread Hans Leidekker
On Wed, 2010-04-21 at 16:18 +0200, Detlef Riekenberg wrote: > static void ShowUsage(int ExitCode) > { > - printf(UsageStr); > +WCHAR msiexec_version[40]; > +WCHAR msiexec_help[4096]; > +WCHAR msi_res[4050]; You should use dynamically sized heap buffers here.

Re: programs/msiexec: sign compare fixes

2009-08-23 Thread Jacek Caban
Hi Austin, static BOOL msi_strequal(LPCWSTR str1, LPCSTR str2) { - DWORD len, ret; + WCHAR len, ret; WCHAR doesn't look like a right type here. Although technically it's integer, it's meant for unicode chars. Jacek

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path. (try 2)

2008-07-31 Thread Lei Zhang
On Thu, Jul 31, 2008 at 1:45 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Lei Zhang" <[EMAIL PROTECTED]> writes: > >> While mucking around in programs/cmd/wcmdmain.c, I noticed >> console = SHGetFileInfo(); >> always returned 0 for just "

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path. (try 2)

2008-07-31 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > While mucking around in programs/cmd/wcmdmain.c, I noticed > console = SHGetFileInfo(); > always returned 0 for just "msiexec". cmd is supposed to build a full path here, but either way it won't work because SHGet

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path. (try 2)

2008-07-31 Thread Lei Zhang
c, I noticed console = SHGetFileInfo(); always returned 0 for just "msiexec". This is part of why running foo.msi from the command prompt does not return immediately, like it does on Windows.

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path. (try 2)

2008-07-31 Thread Alexandre Julliard
tMenuHandlers\{00021401---C000-0046},,0x10, > HKCR,Msi.Package\DefaultIcon,,2,"msiexec.exe" > -HKCR,Msi.Package\shell\Open\command,,2,"msiexec /i ""%1""" > -HKCR,Msi.Package\shell\Repair\command,,2,"msiexec /f ""%1&qu

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path.

2008-07-30 Thread Lei Zhang
On Tue, Jul 29, 2008 at 8:19 PM, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > Lei Zhang wrote: >> Hi, >> >> On Windows, the Msi.Package action registry keys have the full path to >> msiexec.exe. >> >> >> +HKCR,Msi.Package\she

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path.

2008-07-29 Thread Vitaliy Margolen
Lei Zhang wrote: > Hi, > > On Windows, the Msi.Package action registry keys have the full path to > msiexec.exe. > > > +HKCR,Msi.Package\shell\Open\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" > /i ""%1"" %*" > +

Re: [Try 2] A nicer icon for msiexec

2008-03-19 Thread Alexandre Julliard
Hervÿe9 Chanal <[EMAIL PROTECTED]> writes: > It's a nicer icon for msiexec. From the last submit, several size are > now included in the icon file. The icons are generated using a script > i submitted to wine-patch a long time ago. The svg source is not in > this pat

Re: [msiexec] A nicer icon

2007-12-19 Thread Frank Richter
On 19.12.2007 13:04, Alexandre Julliard wrote: > Having icons in .svg format is a nice improvement, but we'll need a tool > to build the .ico from the .svg. We also need to include multiple sizes > in the .ico, most places want a 32x32 icon, and scaling down the 48x48 > looks bad. Of course we shou

Re: [msiexec] A nicer icon

2007-12-19 Thread Alexandre Julliard
Hervÿe9 Chanal <[EMAIL PROTECTED]> writes: > Hello, > > It's a larger nicer icon for msiexec with the svg source. Having icons in .svg format is a nice improvement, but we'll need a tool to build the .ico from the .svg. We also need to include multiple sizes in the

xlviewer install cmdline passed from CreateProcessA to msiexec looks wrong

2007-11-23 Thread Darragh Bailey
OK, long time lurker, only recently decided to try my hand at coding for wine. Picked a bug 9628 and decided to have a bash. Bug occured because a patch to the msiexec command line parsing was reverted due to regressions in the xlviewer installer and other apps. I don't know about the other

Re: msiexec: Add handling for msiexec's regserver option

2006-08-22 Thread James Hawkins
On 8/22/06, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: Tuesday, August 22, 2006, 7:56:00 PM, James Hawkins wrote: > Hi, > More and more installers are expecting the MSI service to exist, or at > least be installable using msiexec /regserver. This patch is the > first step

Re: msiexec: Add handling for msiexec's regserver option

2006-08-22 Thread Vitaliy Margolen
Tuesday, August 22, 2006, 7:56:00 PM, James Hawkins wrote: > Hi, > More and more installers are expecting the MSI service to exist, or at > least be installable using msiexec /regserver. This patch is the > first step in fixing bug 5540. > +if (!scm) > +{ > +

Re: msiexec: msiexec also supports options using a hyphen [RESEND]

2006-07-12 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > Hi, > > Is there anything wrong with this patch? It can't possibly work. Please test it properly before resending it once more. -- Alexandre Julliard [EMAIL PROTECTED]

Re: msiexec: msiexec also supports options using a hyphen [RESEND]

2006-07-12 Thread James Hawkins
On 7/12/06, Alexandre Julliard <[EMAIL PROTECTED]> wrote: "James Hawkins" <[EMAIL PROTECTED]> writes: > Hi, > > Is there anything wrong with this patch? It can't possibly work. Please test it properly before resending it once more. I did test it, and for the option I tested it does work. I

Re: msiexec: msiexec also supports options using a hyphen [RESEND]

2006-07-03 Thread James Hawkins
On 7/3/06, James Hawkins <[EMAIL PROTECTED]> wrote: Hi, Is there anything wrong with this patch? I'll answer my own question :) The version I'm replacing used msi_strprefix and msi_strequal which ignore case, and I've replaced those with direct comparisons to chars, but only the lowercase.

Re: msiexec: msiexec also supports options using a hyphen

2006-06-29 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > Changelog: > * msiexec also supports options using a hyphen. Surely there's a better way to do this than duplicating all the string compares... -- Alexandre Julliard [EMAIL PROTECTED]

Re: msiexec null reference

2005-12-22 Thread Bill Medland
On December 22, 2005 06:15 pm, Mike McCormack wrote: > Bill Medland wrote: > > +static const WCHAR dfv[] = { > > +'M','S',' ','S','h','e','l','l',' ','D','l','g',0 > > }; > > > > > > +if (!dialog->default_font) > > +{ > > +DWORD len = strlenW (dfv) + 1; > > +dial

Re: msiexec null reference

2005-12-22 Thread Mike McCormack
Bill Medland wrote: +static const WCHAR dfv[] = { +'M','S',' ','S','h','e','l','l',' ','D','l','g',0 }; +if (!dialog->default_font) +{ +DWORD len = strlenW (dfv) + 1; +dialog->default_font = msi_alloc(len*sizeof(WCHAR)); +if (!dialog->default_fon

Re: msiexec

2005-05-28 Thread Marcus Meissner
On Thu, May 26, 2005 at 06:46:45PM +0100, Mike Hearn wrote: > > The patch that gives the problem you're (RIchard Cohen) seeing is: > > > > Patch: http://cvs.winehq.org/patch.py?id=14894 > > This is: > > Ivan Leo Puoti <[EMAIL PROTECTED]> > Better EXE version check in VERSION_GetLinke

Re: msiexec

2005-05-26 Thread Sven Paschukat
> So why do you like to install "Microsofts MSI 2.0" ? Do you need it for > another installer? How does this installer fail with the buildin MSI? > > Bye Stefan With builtin MSI there comes a problem at the end of a setup in Installshield X with handling its "Merge Modules": --- sch

Re: msiexec

2005-05-26 Thread Sven Paschukat
Richard Cohen schrieb: The latest version of Wine does have problems with InstMsiA.exe, but I haven't seen this one. I've updated the Wiki page at http://wiki.winehq.com/NativeMsi . Does that work for you? No, the error still occurs. I have to remove the symbolic link to msiexec.exe.so in th

Re: msiexec

2005-05-26 Thread Stefan Leichter
Am Dienstag, 24. Mai 2005 02:21 schrieb Sven Paschukat: > This patch breaks installation of Microsofts MSI 2.0, InstMsiA.exe. > During install with > WINEDLLOVERRIDES="msiexec.exe=n,b" wine InstMsiA.exe > there comes the error: > "Installer besitzt keine ausreichenden Berechtigungen, um > die

Re: msiexec

2005-05-26 Thread Mike Hearn
> The patch that gives the problem you're (RIchard Cohen) seeing is: > > Patch: http://cvs.winehq.org/patch.py?id=14894 This is: Ivan Leo Puoti <[EMAIL PROTECTED]> Better EXE version check in VERSION_GetLinkedDllVersion. (by the way guys, can we get into a habit of posting the l

Re: msiexec

2005-05-26 Thread James Hawkins
On 5/26/05, Richard Cohen <[EMAIL PROTECTED]> wrote: > The latest version of Wine does have problems with InstMsiA.exe, but I > haven't seen this one. I've updated the Wiki page at > http://wiki.winehq.com/NativeMsi . Does that work for you? > The patch that gives the problem you're (RIchard Coh

Re: msiexec

2005-05-26 Thread Richard Cohen
Sven Paschukat wrote: This patch breaks installation of Microsofts MSI 2.0, InstMsiA.exe. During install with WINEDLLOVERRIDES="msiexec.exe=n,b" wine InstMsiA.exe there comes the error: "Installer besitzt keine ausreichenden Berechtigungen, um diese Datei zu verändern: C:\Config.Msi\658-rbf.

Re: msiexec

2005-05-23 Thread Sven Paschukat
This patch breaks installation of Microsofts MSI 2.0, InstMsiA.exe. During install with WINEDLLOVERRIDES="msiexec.exe=n,b" wine InstMsiA.exe there comes the error: "Installer besitzt keine ausreichenden Berechtigungen, um diese Datei zu verändern: C:\Config.Msi\658-rbf." The file is: [EM

Re: MSIEXEC: fix command line parsing

2005-02-08 Thread Alexandre Julliard
Mike McCormack <[EMAIL PROTECTED]> writes: > ChangeLog: > * Fix msiexec's command line parsing. What does msiexec require that the standard command-line parsing cannot support? -- Alexandre Julliard [EMAIL PROTECTED]

Re: MSIEXEC: Make installation of InstMsiA.exe possible

2004-11-06 Thread Tobias Burnus
Hello, Hans Leidekker wrote: I have an InstMsiA.exe that uses two undocumented msiexec command line parameters: /m and /D and uses an undocumented modifier (!) with the /q parameter. Our msiexec fails when it encounters these and responds with a usage message. For /m I found the following, don&#

Re: MSIEXEC: Make installation of InstMsiA.exe possible

2004-11-06 Thread Hans Leidekker
Here's a patch relative to my previous patch that replaces all occurrences of strcasecmp with lstrcmpiA. It also introduces MSIEXEC_lstrncmpiA (wrapper around CompareString) to replace all occurrences of strncasecmp. Changelog: Use string functions that are Windows locale aware. --- progra

Re: MSIEXEC: Make installation of InstMsiA.exe possible

2004-11-06 Thread Dmitry Timoshkov
"Hans Leidekker" <[EMAIL PROTECTED]> wrote: > @@ -523,6 +524,11 @@ > { > InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_PROGRESSONLY; > } > + else if(!strcasecmp(argv[i]+2, "b+!")) Please use lstrcmpiA instead of strcasecmp. A difference between unix system locale and current ANSI cod

Re: Install msiexec in the bin dir while make install.

2004-07-23 Thread Alexandre Julliard
Vincent Béron <[EMAIL PROTECTED]> writes: > Does double-clicking on a .msi package (and thus run msiexec) applies? No, if the user doesn't have to type it then we don't need the binary in /usr/bin, it can always be launched with 'wine msiexec' anyway, so we can pu

Re: Install msiexec in the bin dir while make install.

2004-07-23 Thread Vincent Béron
> the command-line on Windows so that they expect the same behavior on > Wine, or else to apps prefixed with 'wine' as there isn't a risk of > conflict in that case. I'm not sure msiexec qualifies; is it really > something that end users are expected to use on

Re: Install msiexec in the bin dir while make install.

2004-07-23 Thread Alexandre Julliard
else to apps prefixed with 'wine' as there isn't a risk of conflict in that case. I'm not sure msiexec qualifies; is it really something that end users are expected to use on Windows? -- Alexandre Julliard [EMAIL PROTECTED]