Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:15 AM, James Hawkins wrote: > On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: >> On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: >>> On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: fixes bug Bug 17600 ---  dlls/msi/table.c |    

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:18 AM, Aric Stewart wrote: > What appears to be happening is There is an existing table (I am unsure how > many rows it has) > > Then the office installer is doing an Insert on the table as TEMPORARY. > > r = table_create_new_row( view, &row, temporary ); > > returns a r

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread Aric Stewart
What appears to be happening is There is an existing table (I am unsure how many rows it has) Then the office installer is doing an Insert on the table as TEMPORARY. r = table_create_new_row( view, &row, temporary ); returns a row of 0 then under the temporary case we do idx -= tv->table->row

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: > On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: >> On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: >>> >>> fixes bug Bug 17600 >>> --- >>>  dlls/msi/table.c |    3 ++- >>>  1 files changed, 2 insertions(+), 1 deletions(-) >>>

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote: > On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: >> >> fixes bug Bug 17600 >> --- >>  dlls/msi/table.c |    3 ++- >>  1 files changed, 2 insertions(+), 1 deletions(-) >> > > Please add a test case that demonstrates what you're trying t

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread James Hawkins
On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: > > fixes bug Bug 17600 > --- >  dlls/msi/table.c |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) > Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index,