Re: msi: PublishComponents and MsiGetQualifiedComponentExW

2005-04-19 Thread Aric Stewart
Thanks for the pointers, I have resubmitted the patch taking these into account. Index: dlls/msi/msipriv.h === RCS file: /home/wine/wine/dlls/msi/msipriv.h,v retrieving revision 1.52 diff -u -r1.52 msipriv.h --- dlls/msi/msipriv.h

Re: msi: PublishComponents and MsiGetQualifiedComponentExW

2005-04-18 Thread Mike McCormack
Aric Stewart wrote: +WCHAR buf[21]; +WCHAR buf2[21]; It would be nicer to get rid of the magic numbers, and to call the variables something more meaningful than buf1, buf2. +rc = MSI_DatabaseOpenViewW(package->db, ExecSeqQuery, &view); +if (rc != ERROR_SUCCESS) +return ERR