Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-07-03 Thread Kuba Ober
> >PS: PLEASE PLEASE PLEASE ADD YOU COMMENTS BELOW THIS LINE NOT ABOVE. IT'S > >IMPOSSIBLE TO READ. > > By default microsoft outlook, hotmail, all add their replies above the > previous message. It's the way 90% of the email I see works. Just because billions of flies eat sh*t every day, so should

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-06 Thread Jakob Eriksson
EA Durbin wrote: Okay what am i misunderstanding?, explain it to me as its imperative I learn, and I'd love to learn. %u is an unsigned integer which is 0 to +32,767. %u is an unsigned integer which is 0 to +65535. %i is a signed integer –32,767 to +32,767. %i is a signed integer -32768

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-06 Thread Mike Hearn
On Mon, 05 Jun 2006 10:14:50 -0600, Vitaliy Margolen wrote: > So until you show us some code that verifies what you are talking about, > please stay away from the e-mail clinet. He has done exactly that though not in a form we can put in the test suite, and he is not "flaming" anybody. I think you

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Joseph Garvin
EA Durbin wrote: > Okay what am i misunderstanding?, explain it to me as its imperative I > learn, and I'd love to learn. > > %u is an unsigned integer which is 0 to +32,767. > > > %i is a signed integer –32,767 to +32,767. > > If the sequence number is always going to be a positive number why > sh

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Neil Skrypuch
On Monday, June 05, 2006 12:58, EA Durbin wrote: > Okay what am i misunderstanding?, explain it to me as its imperative I > learn, and I'd love to learn. > > %u is an unsigned integer which is 0 to +32,767. > > > %i is a signed integer –32,767 to +32,767. > > If the sequence number is always going

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Jonathan Ernst
Le lundi 05 juin 2006 à 14:01 -0500, EA Durbin a écrit : > > > >Vitaliy. > > > >PS: PLEASE PLEASE PLEASE ADD YOU COMMENTS BELOW THIS LINE NOT ABOVE. IT'S > >IMPOSSIBLE TO READ. > > > > > By default microsoft outlook, hotmail, all add their replies above the > previous message. It's the way 90% o

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
Can you 100% guarantee that documentation is correct? And that there are no broken apps that will try to pass negative number? Vitaliy. Okay, i guess I see your point, but if the broken app passes a negative number its not going to work correctly anyway, as it will read from the wrong Disk

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Vitaliy Margolen
Monday, June 5, 2006, 1:01:10 PM, EA Durbin wrote: >>Both of those depend on the type and not on what it "should be". >>And the type is INT it's a "signed int". > Why must it be a signed int, the comparison is always a positive number > which is an unsigned int. So if we always pass a positive nu

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Detlef Riekenberg
Am Montag, den 05.06.2006, 14:01 -0500 schrieb EA Durbin: > >And the type is INT it's a "signed int". > Why must it be a signed int, Welcome to the World of Microsoft. Another Example from MS: A Function is declared to return a BOOL and documented to return '0', '1' or '2' We are Compatible,

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
Vitaliy. PS: PLEASE PLEASE PLEASE ADD YOU COMMENTS BELOW THIS LINE NOT ABOVE. IT'S IMPOSSIBLE TO READ. By default microsoft outlook, hotmail, all add their replies above the previous message. It's the way 90% of the email I see works. Both of those depend on the type and not on what i

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Vitaliy Margolen
Monday, June 5, 2006, 11:02:38 AM, EA Durbin wrote: > As Robert Shearman stated, why give it a 4 byte value when it's using a 2 > byte value. > The sequence should never be a negative number, where am I mistaken on this? Both of those depend on the type and not on what it "should be". And the typ

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
winehq.org Subject: Re: msi: Fix some copy/paste bugs in the implementation of condition operators. Date: Mon, 5 Jun 2006 10:14:50 -0600 Why would you add all your findings and "test cases" into the Wine's test suite? Until then you should stop flaming list. With all the energy yo

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
extra 32,767 value range? From: Mike McCormack <[EMAIL PROTECTED]> To: EA Durbin <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED], wine-devel@winehq.org, [EMAIL PROTECTED] Subject: Re: msi: Fix some copy/paste bugs in the implementation of condition operators. Date: Tue, 06 Jun 2006 01

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Robert Shearman
Mike McCormack wrote: EA Durbin wrote: It doesn't use %d currently. It uses %i. And its not to print. It uses this value in the SQL statement. The LastSequence value of the Media table is NEVER negative as i pointed out in the MSDN link. It must always be zero or larger and this is handled

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Mike McCormack
EA Durbin wrote: It doesn't use %d currently. It uses %i. And its not to print. It uses this value in the SQL statement. The LastSequence value of the Media table is NEVER negative as i pointed out in the MSDN link. It must always be zero or larger and this is handled by passing %u. Unfortun

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Vitaliy Margolen
y_media_for_files. >>From: Mike McCormack <[EMAIL PROTECTED]> >>To: EA Durbin <[EMAIL PROTECTED]> >>CC: [EMAIL PROTECTED], wine-devel@winehq.org, [EMAIL PROTECTED] >>Subject: Re: msi: Fix some copy/paste bugs in the implementation of >>condition oper

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
Re: msi: Fix some copy/paste bugs in the implementation of condition operators. Date: Tue, 06 Jun 2006 00:38:16 +0900 EA Durbin wrote: I did in fact write a test, which does prove this. Hans has a copy of it, and i think i sent it to wine-devel too. I haven't seen any patch for the Wine

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Mike McCormack
EA Durbin wrote: I did in fact write a test, which does prove this. Hans has a copy of it, and i think i sent it to wine-devel too. I haven't seen any patch for the Wine regression test suite as yet, and that is what I have been asking you to write. As for files.c, the query in ready_media

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
D] Subject: Re: msi: Fix some copy/paste bugs in the implementation of condition operators. Date: Tue, 06 Jun 2006 00:24:00 +0900 EA Durbin wrote: obviously my patch wasn't "wrong" as you so put it, as this is the same thing as the one I submitted. I just phrased the definition of i

Re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Mike McCormack
EA Durbin wrote: obviously my patch wasn't "wrong" as you so put it, as this is the same thing as the one I submitted. I just phrased the definition of it wrong assuming the conditional statements were used by SQL. Your patch caused the regression tests to fail, and Hans' did not. err:msi:m

re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread EA Durbin
ot;Hans Leidekker" <[EMAIL PROTECTED]> CC: "EA Durbin" <[EMAIL PROTECTED]> Subject: re: msi: Fix some copy/paste bugs in the implementation of condition operators. Date: Mon, 5 Jun 2006 08:07:17 -0700 Hans wrote: [http://www.winehq.org/pipermail/wine-cvs/2006-June/0

re: msi: Fix some copy/paste bugs in the implementation of condition operators.

2006-06-05 Thread Dan Kegel
Hans wrote: [http://www.winehq.org/pipermail/wine-cvs/2006-June/023395.html] Fix some copy/paste bugs in the implementation of condition operators. Congratulations on getting your patch into cvs! How far does this go towards fixing America's Army (http://bugs.winehq.org/show_bug.cgi?id=5139)