On Thu, 2010-05-20 at 12:49 +0200, Michael Stefaniuc wrote:
> > It's a header construction where you typically exploit the fact that the
> > header and extended structure start at the same address. So yes, we
> > could leave the code as is.
> "exploit" doesn't sound like a clean approach to me. Th
On Thu, May 20, 2010 at 12:36:21PM +0200, Michael Stefaniuc wrote:
> Paul Vriens wrote:
> > On 05/20/2010 01:15 AM, Michael Stefaniuc wrote:
> >> The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW
> >> returns NULL there is a crash.
> >> ---
> >> dlls/msi/msi.c |3 ++-
> >
Hans Leidekker wrote:
> On Thu, 2010-05-20 at 10:03 +0200, Paul Vriens wrote:
>
The main reason I'm asking is because we have several of these lingering
around (and marked as 'FALSE' in Coverity).
>>> In this particular case we should just get rid of the goto.
>>>
>>>
>> But is it a (pot
Paul Vriens wrote:
> On 05/20/2010 01:15 AM, Michael Stefaniuc wrote:
>> The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW
>> returns NULL there is a crash.
>> ---
>> dlls/msi/msi.c |3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/dlls/msi/
On Thu, 2010-05-20 at 10:03 +0200, Paul Vriens wrote:
> >> The main reason I'm asking is because we have several of these lingering
> >> around (and marked as 'FALSE' in Coverity).
> >
> > In this particular case we should just get rid of the goto.
> >
> >
> But is it a (potential) issue? I guess
On 05/20/2010 10:00 AM, Hans Leidekker wrote:
On Thu, 2010-05-20 at 08:04 +0200, Paul Vriens wrote:
The main reason I'm asking is because we have several of these lingering
around (and marked as 'FALSE' in Coverity).
In this particular case we should just get rid of the goto.
But is it a (p
On Thu, 2010-05-20 at 08:04 +0200, Paul Vriens wrote:
> The main reason I'm asking is because we have several of these lingering
> around (and marked as 'FALSE' in Coverity).
In this particular case we should just get rid of the goto.
On 05/20/2010 07:55 AM, Paul Vriens wrote:
On 05/20/2010 01:15 AM, Michael Stefaniuc wrote:
The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW
returns NULL there is a crash.
---
dlls/msi/msi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/dlls/msi/ms
On 05/20/2010 01:15 AM, Michael Stefaniuc wrote:
The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW
returns NULL there is a crash.
---
dlls/msi/msi.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c
index 3170e6d..9
