Re: msi/tests: Test type for INT column.

2009-04-27 Thread Hib Eris
Hi Hans, Sorry for this, but my patch just contained a typo, 'Intvalue' and 'IntValue' are just strings that can be set to anything but should match. I have already sent in new patches for this, but because I am not on the mailinglist they take some time to arrive. However, these patches are alrea

msi/tests: Test type for INT column.

2009-04-27 Thread Hib Eris
Hi all, I have just send in my first patch to wine-patches. Unfortunately it contains a small mistake. My apologies for that. I will resend a correct patch soon. I guess I was just too happy with my patch and wanted to share it as soon as possible.. or actually more soon than possible. Kind rega

Re: msi/tests: Test type for INT column.

2009-04-25 Thread Hans Leidekker
> -"( `Property` CHAR(255), `Value` CHAR(1) PRIMARY KEY > `Property`)" ); > +"( `Property` CHAR(255), `Value` CHAR(1), `Intvalue` INT PRIMARY > KEY `Property`)" ); > ok( r == ERROR_SUCCESS , "Failed to create table\n" ); ... > ok( check_record( rec, 2, "Value"),

Re: msi/tests: Test type for INT column.

2009-04-25 Thread Austin English
On Sat, Apr 25, 2009 at 9:55 AM, Hib Eris wrote: > This patch adds a check for the type of INT columns in msi database tables. > > > --- >  dlls/msi/tests/db.c |    5 - >  1 files changed, 4 insertions(+), 1 deletions(-) > > > > Howdy Hib, You need to wrap failing tests in todo_wine, e.g., f