Re: mscoree: Implement ICorDebug SetManagedHandler (try 3)

2011-10-10 Thread Vincent Povirk
Can we have a WARN message in case of .NET 1 applications? On Mon, Oct 10, 2011 at 2:36 PM, Alistair Leslie-Hughes wrote: > On 11/10/2011 2:07 AM, Vincent Povirk wrote: >> >> Should SetManagedHandler really fail if the given object doesn't >> support ICorDebugManagedCallback2 ? > > Yes, this is a

Re: mscoree: Implement ICorDebug SetManagedHandler (try 3)

2011-10-10 Thread Alistair Leslie-Hughes
On 11/10/2011 2:07 AM, Vincent Povirk wrote: Should SetManagedHandler really fail if the given object doesn't support ICorDebugManagedCallback2 ? Yes, this is a requirement for debugging .NET 2 applications. Best Regards Alistair Leslie-Hughes

Re: mscoree: Implement ICorDebug SetManagedHandler (try 3)

2011-10-10 Thread Vincent Povirk
t; Only Release the interfaces after we have a valid callback. > Allow multiple Interfaces per runtime. > > > Changelog: >      mscoree: Implement ICorDebug SetManagedHandler > > > Best Regards >   Alistair Leslie-Hughes > > > > > >

Re: mscoree: Implement ICorDebug SetManagedHandler (try 2)

2011-10-06 Thread Vincent Povirk
Still not sure there should be only one ICorDebug per runtime host. It seems like you might want to create multiple interfaces and use them independently.

Re: mscoree: Implement ICorDebug SetManagedHandler (try 2)

2011-10-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14737 Your paranoid android

Re: mscoree: Implement ICorDebug SetManagedHandler

2011-10-05 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > @@ -99,8 +99,28 @@ static HRESULT WINAPI CorDebug_Terminate(ICorDebug *iface) > static HRESULT WINAPI CorDebug_SetManagedHandler(ICorDebug *iface, > ICorDebugManagedCallback *pCallback) > { > RuntimeHost *This = impl_from_ICorDebug( iface ); > -FIXME("