Re: mscoree: Add ICorDebug interface support (try 3)

2011-09-28 Thread Vincent Povirk
, Alistair Leslie-Hughes wrote: > Hi, > Changed to use ICLRRuntimeInfo::GetInterface, suggest by Vincent. > Moved the #undef to the header. > > > Changelog: >      mscoree: Add ICorDebug interface support > > > Best Regards >   Alistair Leslie-Hughes > > > > > >

Re: mscoree: Add ICorDebug interface support (try 3)

2011-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14599 Your paranoid android

Re: mscoree: Add ICorDebug interface support (try 2)

2011-09-27 Thread Vincent Povirk
-Hughes wrote: > Hi, > Add missing test file. > > Changelog: >     mscoree: Add ICorDebug interface support > > > Best Regards >  Alistair Leslie-Hughes > > > > >

Re: mscoree: Add ICorDebug interface support

2011-09-27 Thread Vincent Povirk
Why aren't you using CLRRuntimeInfo_GetInterface for this?

Re: mscoree: Add ICorDebug interface support (try 2)

2011-09-27 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > +#include "initguid.h" > +/* We need to undefine the MACRO CreateProcess since the ICorDebug interface > +has a function with this name. (Stops a compile issue). > + */ > +#undef CreateProcess > +#include "cordebug.h" This should go in the header. Check how o

Re: 79358: mscoree: Add ICorDebug interface support

2011-09-27 Thread Dan Kegel
build failed here - did you forget a file? ../../tools/makedep -C. -S../.. -T../.. assembly.c config.c cordebug.c corruntimehost.c metadata.c metahost.c mscoree_main.c debugging.c: No such file or directory make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox

Re: mscoree: Add ICorDebug interface support (try 2)

2011-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14582 Your paranoid android

Re: mscoree: Add ICorDebug interface support

2011-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14581 Your paranoid android