Re: msacm: pcm compatibility patch

2004-12-11 Thread Mike Hearn
On Sat, 11 Dec 2004 09:29:21 -0500, Robert Reif wrote: > The Microsoft code will not read and/or > write the entire contents of the buffers under some > circumstances. Duplicating this behavior lead to the code I > have presented. What bugs did this behaviour cause? If it's purely a matter of cor

Re: msacm: pcm compatibility patch

2004-12-11 Thread Robert Reif
Eric Pouech wrote: I'd agree that what we don't need byte compatibility for the audio conversions. We should be compatible OTOH on the size of the buffers sent out (not sure it's always the case), which may cause some problems in some cases. A+ The number of bytes read and written was the orig

Re: msacm: pcm compatibility patch

2004-12-11 Thread Christian Costa
Eric Pouech wrote: Christian Costa a écrit : Hi Robert, Robert Reif wrote: Makes the PCM conversion routines of msacm produce identical results to the native dll. Allow any PCM to PCM conversion, not just advertised ones. The algorithms used by Microsoft in this dll are very crude and produce an

Re: msacm: pcm compatibility patch

2004-12-11 Thread Eric Pouech
Christian Costa a écrit : Hi Robert, Robert Reif wrote: Makes the PCM conversion routines of msacm produce identical results to the native dll. Allow any PCM to PCM conversion, not just advertised ones. The algorithms used by Microsoft in this dll are very crude and produce an output of much poor

Re: msacm: pcm compatibility patch

2004-12-11 Thread Christian Costa
Hi Robert, Robert Reif wrote: Makes the PCM conversion routines of msacm produce identical results to the native dll. Allow any PCM to PCM conversion, not just advertised ones. The algorithms used by Microsoft in this dll are very crude and produce an output of much poorer quality than what is cu