mpr: fix a compiler error on PowerPC

2009-01-09 Thread Steven Edwards
-- Forwarded message -- From: art yerkes Date: 2009/1/9 Subject: Re: mpr: fix a compiler error on PowerPC To: Steven Edwards According to Art Yerkes who has a copy of PPC VC++ "Here's what I get. The first test (char) works identically to the second test (signed cha

Re: mpr: fix a compiler error on PowerPC

2009-01-09 Thread Alexandre Julliard
Francois Gouget writes: > On Fri, 9 Jan 2009, Alexandre Julliard wrote: > >> Sure, but we would do that by adding -fsigned-char in winegcc, not by >> making CHAR and char two different types. > > Oh. Good point. I forgot about that one. I guess that's a hint for > Austin ... No, we don't want t

Re: mpr: fix a compiler error on PowerPC

2009-01-09 Thread Austin English
On Fri, Jan 9, 2009 at 4:17 PM, Francois Gouget wrote: > On Fri, 9 Jan 2009, Alexandre Julliard wrote: > >> Francois Gouget writes: >> >> > On Fri, 9 Jan 2009, Alexandre Julliard wrote: >> > >> >> No, CHAR is really supposed to be the same thing as char, since it's >> >> used for strings. Otherwi

Re: mpr: fix a compiler error on PowerPC

2009-01-09 Thread Francois Gouget
On Fri, 9 Jan 2009, Alexandre Julliard wrote: > Francois Gouget writes: > > > On Fri, 9 Jan 2009, Alexandre Julliard wrote: > > > >> No, CHAR is really supposed to be the same thing as char, since it's > >> used for strings. Otherwise you'll need casts all over the place. > > > > Ideally we'd ch

Re: mpr: fix a compiler error on PowerPC

2009-01-09 Thread Alexandre Julliard
Francois Gouget writes: > On Fri, 9 Jan 2009, Alexandre Julliard wrote: > >> No, CHAR is really supposed to be the same thing as char, since it's >> used for strings. Otherwise you'll need casts all over the place. > > Ideally we'd check whether 'char' was signed or unsigned in Visual C++ > for

Re: mpr: fix a compiler error on PowerPC

2009-01-09 Thread Francois Gouget
On Fri, 9 Jan 2009, Alexandre Julliard wrote: > Francois Gouget writes: > > > On Fri, 2 Jan 2009, Austin English wrote: > > > >> CHAR defaults to unsigned char on PowerPC, so explicitly setting hi/lo > >> to signed char to avoid this error. > > > > CHAR is a Windows type so I don't think it's ri

Re: mpr: fix a compiler error on PowerPC

2009-01-09 Thread Alexandre Julliard
Francois Gouget writes: > On Fri, 2 Jan 2009, Austin English wrote: > >> CHAR defaults to unsigned char on PowerPC, so explicitly setting hi/lo >> to signed char to avoid this error. > > CHAR is a Windows type so I don't think it's right for it to be unsigned > on PowerPC. Even more so since the

Re: mpr: fix a compiler error on PowerPC

2009-01-09 Thread Francois Gouget
On Fri, 2 Jan 2009, Austin English wrote: > CHAR defaults to unsigned char on PowerPC, so explicitly setting hi/lo > to signed char to avoid this error. CHAR is a Windows type so I don't think it's right for it to be unsigned on PowerPC. Even more so since there is a UCHAR type. So I think the