Re: mmdevapi/tests: test MMDevPropStore_GetAt

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2403 Your paranoid andr

Re: [PATCH 3/4] mmdevapi/tests: Perform renderer padding & position tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16887 Your paranoid android

Re: [PATCH 4/4] mmdevapi/tests: Check GetService's output parameter.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16888 Your paranoid android

Re: mmdevapi/tests: Perform renderer padding & position tests.

joerg-cyril.hoe...@t-systems.com writes: > Could you please investigate this? > The crash happens in test_session, before the one change to this > function by my patch. That would be easier to do if you sent smaller patches... -- Alexandre Julliard julli...@winehq.org

mmdevapi/tests: Perform renderer padding & position tests.

in winealsa 2 test_session+0x114() [dlls/mmdevapi/tests/render.c:1298] in mmdevapi_test Could you please investigate this? The crash happens in test_session, before the one change to this function by my patch. The tests have been running thousands of iterations on my dual core MacOS (with my wi

Re: mmdevapi/tests: Perform renderer padding & position tests.

evapi_test.exe.so ../../../../wine/dlls/mmdevapi/tests/render.c && touch render.ok render.c:1081: Tests skipped: Rerun with WINETEST_DEBUG=2 for GetPosition tests. render.c:1081: Tests skipped: Rerun with WINETEST_DEBUG=2 for GetPosition tests. wine: Unhandled page fault on read access to 0xff

mmdevapi/tests: Add format tests.

Hi, Andrew Eikum wrote: > +todo_wine ok(broken(unk != NULL), ... I'll comment on that separately. >> +static void test_formats(AUDCLNT_SHAREMODE mode) >The code in this function is very difficult to follow. Indeed, it became more and more convoluted as I dug into native's "exclusive mode dis

Re: mmdevapi/tests: Add format tests.

Hi J�rg, Thanks for adding these tests. It would have been nicer to split the patch up into discrete chunks. That would make the patch much easier to review. Overall it looks pretty good. Some remarks follow... > BTW, I've not touched > render.c:223: Test failed: IsFormatSupported(0x) cal

Re: mmdevapi tests

On 08/02/2011 09:30 AM, joerg-cyril.hoe...@t-systems.com wrote: I've a couple of mmdevapi tests that I could put into submittable form soon, however there's one big problem: There are three different backends (ALSA, OSS, MacOS) and each one needs a different set of todo_wine. How to

mmdevapi tests

Hi, I've a couple of mmdevapi tests that I could put into submittable form soon, however there's one big problem: There are three different backends (ALSA, OSS, MacOS) and each one needs a different set of todo_wine. How to deal with that? In the past, when I worked alone (e.g. on t

mmdevapi/tests: Fix wrong buffer unit and memory leaks.

Hi, >* nBlockAlign is wrong since data is counted in frames, not bytes. I forgot to comment that I introduced the 10x multiplicator to convince myself that GetData accepts buffer sizes larger than the default 10ms chunk returned by GetDevicePeriod. That is reasonable, but not guaranteed when I re

Re: [PATCH 9/9] mmdevapi/tests: Add tests for volume control interfaces

Andrew Eikum writes: > --- > dlls/mmdevapi/tests/capture.c | 389 > ++ > dlls/mmdevapi/tests/render.c | 414 > + > 2 files changed, 803 insertions(+), 0 deletions(-) It doesn't work here: ..

Re: [PATCH 6/6] mmdevapi/tests: Add tests for IAudioClock

Andrew Eikum writes: > +pcpos = 0; > +hr = IAudioClock_GetPosition(acl, &pos, &pcpos); > +ok(hr == S_OK, "GetPosition failed: %08x\n", hr); > +ok(pos == 0, "GetPosition returned non-zero pos before being started: > %lld\n", pos); Please avoid %ll formats. -- Alexandre Julliard

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.

On Thu, Jul 29, 2010 at 6:50 PM, Alexandre Julliard wrote: > That's ugly, you should check the function result, not a magic pointer > value. I wanted to differentiate between the various cases in which the function can fail, but I guess that's not really required. I'll send another version. What

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.

Octavian Voicu writes: > @@ -190,25 +190,31 @@ static void test_audioclient(IAudioClient *ac) > hr = IAudioClient_GetMixFormat(ac, NULL); > ok(hr == E_POINTER, "GetMixFormat returns %08x\n", hr); > > +pwfx = (void *)0xdeadbeef; > hr = IAudioClient_GetMixFormat(ac, &pwfx); >

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.

On Thu, Jul 29, 2010 at 3:57 AM, Octavian Voicu wrote: > Test results from test.winehq.org show that GetMixFormat consistently > fails on some configurations (usually for both capture and render, > sometimes only for capture). I also found out why GetMixFormat fails on my system (Kubuntu 10.04).

Patch for mmdevapi/tests/dependency.c

Hi Maarten, Your patch to fix the test failure for boxes with no soundcard was not committed (yet?). Would the following patch be ok? It also includes more cleanup. -- Cheers, Paul. diff --git a/dlls/mmdevapi/tests/dependency.c b/dlls/mmdevapi/tests/dependency.c index 1568bed..9b3be0f