Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 3)

2013-03-15 Thread Alexandre Julliard
writes: > The only comments about v2 were Michael Stefaniuc > suggesting a refactoring and me explaining why > in this particular case, that would not be a good idea. > http://www.winehq.org/pipermail/wine-devel/2013-March/099068.html It's still a good idea, even if the function is ultimately us

mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 2)

2013-03-05 Thread Joerg-Cyril.Hoehle
Hi, Michael Stefaniuc wrote: >But I see that even the whole functionality can move to a helper. That's not a good idea: While the code currently contains two identical pieces of code, it is actually bogus because the capture part should *not* store current time rather than get *recorded* time. Th

mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 2)

2013-03-01 Thread Joerg-Cyril.Hoehle
Michael Stefaniuc wrote: >My idea was to have the whole if else in an inline function. That's understandable. However in this particular case, we know that in Wine QueryPerfFrequency now yields 1000, thus Muldiv64 is dead code actually. So I decided to keep the if (freq == 1000) return i

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 2)

2013-03-01 Thread Michael Stefaniuc
Hello Joerg, On 03/01/2013 10:22 AM, joerg-cyril.hoe...@t-systems.com wrote: > The idea to replace X * numerator / denominator > by X / den * mul + remainder from euclidian division > came from > http://blog.airsource.co.uk/index.php/2010/03/15/quelle-heure-est-il/ > > M. Stefaniuc suggested an i

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use.

2013-02-27 Thread Michael Stefaniuc
Hello Joerg, On 02/27/2013 02:46 PM, joerg-cyril.hoe...@t-systems.com wrote: The idea to replace X * numerator / denominator by X / den * mul + remainder from euclidian division came from can you please use an inline function for that? http://blog.airsource.co.uk/index.php/2010/03/15/quelle-h