Re: mlang/tests: don't assume output of ConvertStringFromUnicode is null terminated

2008-07-07 Thread James Hawkins
On Mon, Jul 7, 2008 at 12:08 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Sun, Jul 6, 2008 at 10:29 AM, James Hawkins <[EMAIL PROTECTED]> wrote: >> No, this is hiding a bug. The test code conforms with the API. The >> problem is that ConvertINetMultiByteToUnicode uses the value of an >> out-only

Re: mlang/tests: don't assume output of ConvertStringFromUnicode is null terminated

2008-07-06 Thread Dan Kegel
On Sun, Jul 6, 2008 at 10:29 AM, James Hawkins <[EMAIL PROTECTED]> wrote: > No, this is hiding a bug. The test code conforms with the API. The > problem is that ConvertINetMultiByteToUnicode uses the value of an > out-only parameter (NULL pDstStr, non-NULL pcDstSize). Check out the > code block

Re: mlang/tests: don't assume output of ConvertStringFromUnicode is null terminated

2008-07-06 Thread James Hawkins
2008/7/6 Dan Kegel <[EMAIL PROTECTED]>: > The mlang test assumed that the output of ConvertStringFromUnicode > was null terminated, but it seems not to be. > > Fixes the valgrind warning: > Conditional jump or move depends on uninitialised value(s) > at strlen (mc_replace_strmem.c:242) > by lst