Re: Missed patches concerning valgrind-detected issues

2008-07-29 Thread Kirill K. Smirnov
В сообщении от 29 июля 2008 Alexandre Julliard написал(a): > "Kirill K. Smirnov" <[EMAIL PROTECTED]> writes: > > Hello, Alexandre, > > > > dsound: check error status of waveOutGetVolume() function before using > > retrieved values (found by valgrind) > > http://www.winehq.org/pipermail/wine-patch

Re: Missed patches concerning valgrind-detected issues

2008-07-29 Thread Alexandre Julliard
"Kirill K. Smirnov" <[EMAIL PROTECTED]> writes: > Hello, Alexandre, > > Is there anything wrong with this couple of patches: > > dsound: check error status of waveOutGetVolume() function before using > retrieved values (found by valgrind) > http://www.winehq.org/pipermail/wine-patches/2008-July/0

Missed patches concerning valgrind-detected issues

2008-07-28 Thread Kirill K. Smirnov
Hello, Alexandre, Is there anything wrong with this couple of patches: dsound: check error status of waveOutGetVolume() function before using retrieved values (found by valgrind) http://www.winehq.org/pipermail/wine-patches/2008-July/058124.html and cmd: Do not deceive CompareString() passing

Missed Patches

2008-06-23 Thread Alistair Leslie-Hughes
Hi, Any wrong with my patches gdi32: stop crash in font tests mapi32: stop crash under win98 secur32: fix crash under win98 shell32: Stop crash when an error occurs msxml3: Added xml Input Callbacks to support loading files from a Wine windows drive Best Regards Alistair Leslie-Hughes

missed patches

2008-01-03 Thread Kirill K. Smirnov
Hi, Is there something wrong with these couple of patches? http://www.winehq.org/pipermail/wine-patches/2007-December/048436.html kernel32/console: convert newborn wineserver handle to kernel32 console handle. This patch makes screenbuffer handle, returned by CreateConsoleScreenBuffer function

Re: Missed Patches

2007-11-20 Thread Alistair Leslie-Hughes
"Jacek Caban" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Alistair Leslie-Hughes wrote: >> Any other pointers? >> > This interface shouldn't be available in BSCallback. You probably added > it because of the FIXME message. I've sent a patch that silences it. In > the future you

Re: Missed Patches

2007-11-19 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Any other pointers? > This interface shouldn't be available in BSCallback. You probably added it because of the FIXME message. I've sent a patch that silences it. In the future you should check if interface is available in Windows before adding them to Wine. Jace

Re: Missed Patches

2007-11-19 Thread Alistair Leslie-Hughes
"Jacek Caban" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Alistair Leslie-Hughes wrote: >> Hi, >> Is there any reason the following patches haven't been applied? >> > [...] > >> mshtml: Provide support for the IInternetProtocol Interface >> > > The patch is obviously wrong.

Re: Missed Patches

2007-11-19 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi, > Is there any reason the following patches haven't been applied? > [...] > mshtml: Provide support for the IInternetProtocol Interface > The patch is obviously wrong. Did you run tests with Gecko installed? It probably won't fail, but you will see so

Missed Patches

2007-11-19 Thread Alistair Leslie-Hughes
Hi, Is there any reason the following patches haven't been applied? [1/2] msxml: Implement createTextNode [2/2] msxml: Tests for createTextNode mshtml: Provide support for the IInternetProtocol Interface Best Regards Alistair Leslie-Hughes