Re: mciwave: Rework MCI notification system.

2009-11-10 Thread Paul Vriens
On 11/10/2009 12:56 PM, joerg-cyril.hoe...@t-systems.com wrote: Hi, same patch as yesterday, with more spaces and volatile and mciSave fix thrown out. I was about to resend [PATCH 2] winmm: MCI Close all causes one notification per open driver. which I rebased as well when I realised that it's

Re: [PATCH 4] mciwave: Rework MCI notification system.

2009-11-09 Thread Vitaliy Margolen
Vitaliy Margolen wrote: > joerg-cyril.hoe...@t-systems.com wrote: >> +HANDLE old = InterlockedExchangePointer(&wmw->hCallback, NULL); >> +if (old) mciDriverNotify(old,wDevID,MCI_NOTIFY_SUPERSEDED); >> +mciDriverNotify(HWND_32(LOWORD(hWndCallBack)),wDevID,wStatus); > Here and everywhere

Re: [PATCH 4] mciwave: Rework MCI notification system.

2009-11-09 Thread Vitaliy Margolen
joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > + * Notifications in MCI work like a 1-element queue. > + * Each new notification request supersedes the previous one. > +volatile HANDLEhCallback; /* Callback handle for > pending notification */ You do not need volatile her