Re: loader: more stringent sanity check

2008-03-21 Thread Darragh Bailey
On Fri, Mar 21, 2008 at 03:56:08AM -0500, Austin English wrote: > On Fri, Mar 21, 2008 at 3:37 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > That's a good point, we could certainly prevent running wineprefixcreate > > as root in that case too, that would probably solve most of the > > p

Re: loader: more stringent sanity check

2008-03-21 Thread Austin English
On Fri, Mar 21, 2008 at 3:37 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Austin English" <[EMAIL PROTECTED]> writes: > > > I suspect it's more often people sudo'ing. I haven't tried it, but I > > know that Alexandre committed a fix that checks if you're running with > > sudo after the i

Re: loader: more stringent sanity check

2008-03-21 Thread Alexandre Julliard
"Austin English" <[EMAIL PROTECTED]> writes: > I suspect it's more often people sudo'ing. I haven't tried it, but I > know that Alexandre committed a fix that checks if you're running with > sudo after the inital .wine directory is made, but I'm not sure about > what happens if you do it initially

Re: loader: more stringent sanity check

2008-03-21 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Many, many newbies are running wine as root without > really needing to. They are much more likely to screw > up their systems this way. Are you saying we should stop > advising against this? I have seen very little evidence that anybody screwed up thei

Re: loader: more stringent sanity check

2008-03-21 Thread Marcus Meissner
On Thu, Mar 20, 2008 at 09:48:31PM -0600, Vitaliy Margolen wrote: > Austin English wrote: > > On Thu, Mar 20, 2008 at 6:40 PM, Lei Zhang <[EMAIL PROTECTED]> wrote: > >> On Ubuntu, you cannot even login as root, they'd have to run "sudo > >> wine". On many other distros, if you login as root, you'

Re: loader: more stringent sanity check

2008-03-20 Thread Vitaliy Margolen
Austin English wrote: > On Thu, Mar 20, 2008 at 6:40 PM, Lei Zhang <[EMAIL PROTECTED]> wrote: >> On Ubuntu, you cannot even login as root, they'd have to run "sudo >> wine". On many other distros, if you login as root, you'll get a >> dialog warning you about it, and the desktop background will

Re: loader: more stringent sanity check

2008-03-20 Thread Austin English
On Thu, Mar 20, 2008 at 6:40 PM, Lei Zhang <[EMAIL PROTECTED]> wrote: > On Ubuntu, you cannot even login as root, they'd have to run "sudo > wine". On many other distros, if you login as root, you'll get a > dialog warning you about it, and the desktop background will be bright > red. Are peopl

Re: loader: more stringent sanity check

2008-03-20 Thread Lei Zhang
On Thu, Mar 20, 2008 at 4:28 PM, Marcus Meissner <[EMAIL PROTECTED]> wrote: > On Thu, Mar 20, 2008 at 03:41:00PM -0700, Dan Kegel wrote: > > On Thu, Mar 20, 2008 at 3:28 PM, Alexandre Julliard <[EMAIL PROTECTED]> > wrote: > > > I hope you are not seriously suggesting that we do this... > > >

Re: loader: more stringent sanity check

2008-03-20 Thread Dan Kegel
On Thu, Mar 20, 2008 at 4:28 PM, Marcus Meissner <[EMAIL PROTECTED]> wrote: > > Many, many newbies are running wine as root without > > really needing to. > > QUestion is ... Why do they do this? They don't know any better...

Re: loader: more stringent sanity check

2008-03-20 Thread Marcus Meissner
On Thu, Mar 20, 2008 at 03:41:00PM -0700, Dan Kegel wrote: > On Thu, Mar 20, 2008 at 3:28 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > I hope you are not seriously suggesting that we do this... > > Seriously. > > > I'm not at all convinced that we need even a warning, there doesn't see

Re: loader: more stringent sanity check

2008-03-20 Thread Dan Kegel
On Thu, Mar 20, 2008 at 4:11 PM, Christopher Buck <[EMAIL PROTECTED]> wrote: > Strictly speaking, running as root is a OS level issue, not a wine > issue. Wine is a newbie magnet, though; it's what pulls a lot of Windows users onto this OS. So it's kind of our fault, it's best if we clean up the

Re: loader: more stringent sanity check

2008-03-20 Thread Christopher Buck
Strictly speaking, running as root is a OS level issue, not a wine issue. That being said, wine is being friendly if it notes the possible issues with running as root. That being said, letting the user know the bypass switch or when wine doesn't start up right away is also friendly. Perhaps we

Re: loader: more stringent sanity check

2008-03-20 Thread Dan Kegel
On Thu, Mar 20, 2008 at 3:55 PM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > >> If we really need to have something then it should be at most a one-time > >> warning (in a message box so people have a chance to see it) at > >> wineprefixcreate time, with an easy way to disable it. > > >

Re: loader: more stringent sanity check

2008-03-20 Thread Michael Stefaniuc
Dan Kegel wrote: > On Thu, Mar 20, 2008 at 3:28 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> I hope you are not seriously suggesting that we do this... > > Seriously. > >> I'm not at all convinced that we need even a warning, there doesn't seem >> to be much concrete evidence that runn

Re: loader: more stringent sanity check

2008-03-20 Thread Dan Kegel
On Thu, Mar 20, 2008 at 3:28 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > I hope you are not seriously suggesting that we do this... Seriously. > I'm not at all convinced that we need even a warning, there doesn't seem > to be much concrete evidence that running as root is actually harm

Re: loader: more stringent sanity check

2008-03-20 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > +if (!strcmp( argv[1], "--nosanitycheck" )) > +{ > +perform_sanity_check = 0; > + > +/* Delete --nosanitycheck from argv */ > + > +/* Size of argv before is argc +1 for argv[0], +1 for argv[argc]=0 */ > +/* Size of a