Re: listview crash fix

2005-09-26 Thread Dimi Paun
On Mon, 2005-09-26 at 08:22 -0700, Duane Clark wrote: > It seems to fix the problem for me. Cool, thanks for the response, I'll submit a patch soon. -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: listview crash fix

2005-09-26 Thread Duane Clark
Dimi Paun wrote: On Mon, 2005-09-26 at 03:29 +0200, Michael Jung wrote: Sorry, I'm currently on vacation in Peru and won't be able to test this for the next three weeks. It's OK, I guess it can wait until you come back, or maybe Phil can take it for a spin in the meantime. It seems to fix t

Re: listview crash fix

2005-09-25 Thread Dimi Paun
On Mon, 2005-09-26 at 03:29 +0200, Michael Jung wrote: > Sorry, I'm currently on vacation in Peru and won't be able to test > this for the next three weeks. It's OK, I guess it can wait until you come back, or maybe Phil can take it for a spin in the meantime. -- Dimi Paun <[EMAIL PROTECTED]> La

Re: listview crash fix

2005-09-25 Thread Michael Jung
Hi Dimi, On Fri, 23 Sep 2005, Dimi Paun wrote: > Is this one working for you? Sorry, not much tested here > other than a quick compile, it's past 2:30am already... Sorry, I'm currently on vacation in Peru and won't be able to test this for the next three weeks. Bye, -- Michael Jung [EMAIL PROTE

Re: listview crash fix

2005-09-22 Thread Dimi Paun
Is this one working for you? Sorry, not much tested here other than a quick compile, it's past 2:30am already... -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc. Index: dlls/comctl32/listview.c === RCS file: /var/cvs/wine/dlls/comctl32

Re: listview crash fix

2005-09-16 Thread Michael Jung
Hi Dimi, On Friday 16 September 2005 14:41, Dimi Paun wrote: > Try this instead, I forgot you're not supposed to return > directly out of a __TRY block. Seems to work fine for me (I had to add an ntdll import to the Makefile to get it to link). No crashes thus far. Bye, -- Michael Jung [EMAIL

Re: listview crash fix

2005-09-16 Thread Alexandre Julliard
Dimi Paun <[EMAIL PROTECTED]> writes: > OK, here it is, using exceptions instead of cluttering the > code with tests all over the place. Obviously, it is much > cleaner then other methods, but we've I know we've been > hesitant to use exceptions in Wine unless absolutely > necessary due to the c

Re: listview crash fix

2005-09-16 Thread Dimi Paun
On Fri, 2005-09-16 at 08:12 -0400, Dimi Paun wrote: > On Wed, 2005-09-14 at 15:16 +0200, Michael Jung wrote: > > > To be honest, I don't like this solution at all, I'll try > > > a different approach tonight, but in the meanwhile... > > OK, here it is, using exceptions [...] Try this instead, I f

Re: listview crash fix

2005-09-16 Thread Dimi Paun
On Wed, 2005-09-14 at 15:16 +0200, Michael Jung wrote: > > To be honest, I don't like this solution at all, I'll try > > a different approach tonight, but in the meanwhile... OK, here it is, using exceptions instead of cluttering the code with tests all over the place. Obviously, it is much cleane

Re: listview crash fix

2005-09-14 Thread Dimi Paun
From: "Michael Jung" <[EMAIL PROTECTED]> > Thanks, seems to work fine for me (no crash while browsing about 50 > directories). Good, thanks. > I've attached another patch, which fixes the crash in the file dialog applying > this scheme. I've only changed as much as necessary to fix the problem, >

Re: listview crash fix

2005-09-14 Thread Michael Jung
Hi Dimi, On Wednesday 14 September 2005 14:24, Dimi Paun wrote: > Can you try this out and let me know if it works please? Thanks, seems to work fine for me (no crash while browsing about 50 directories). > To be honest, I don't like this solution at all, I'll try > a different approach tonigh

listview crash fix

2005-09-14 Thread Dimi Paun
Hi Michael, Can you try this out and let me know if it works please? To be honest, I don't like this solution at all, I'll try a different approach tonight, but in the meanwhile... -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc. Index: dlls/comctl32/listview.c