Re: list view completely mangled in WINE

2004-08-06 Thread Filip Navara
Dan Kegel wrote: Hi Filip, if you're looking for testcases, could you try the demo programs in http://bugs.winehq.org/show_bug.cgi?id=1268 and Sort of works. All the items are displayed, but when I switch to "Large Icons" mode all the items are placed at the position 0,0 above themselves. http:/

Re: list view completely mangled in WINE

2004-08-05 Thread Dan Kegel
Hi Filip, if you're looking for testcases, could you try the demo programs in http://bugs.winehq.org/show_bug.cgi?id=1268 and http://bugs.winehq.org/show_bug.cgi?id=1404 ? Especially the latter one, which has a tiny MFC demo program in both source code form and precompiled. It misbehaves badly wi

Re: list view completely mangled in WINE

2004-08-05 Thread Tobias Burnus
Hello, Tobias Burnus wrote: The patch improves the situation a lot! Even Save List works now! Thanks! I have another strangeness with multi-select lists (e.g. the lists in Diamond but this might affect other lists as well): * I go to a line, press shift and then the arrow keys. If I use arrow dow

Re: list view completely mangled in WINE

2004-08-03 Thread Tobias Burnus
Hello, Dimitrie O. Paun wrote: BTW, I've tried to install the demo, but the installer dies on my version of wine. Does it work for you, or did you use Windows for the installation? I used WINE (more precisely CrossOver Office 3.0.1 and CXO nightly) to install the program, which worked flawlessly.

Re: list view completely mangled in WINE

2004-08-03 Thread Filip Navara
Dimitrie O. Paun wrote: [snip] Almost. If it does go in though, we need to: -- fix a few more places where we look at WS_[VH]SCROLL Ok, I have that done in my local tree and will send it tonight propably. -- understand why did the listview work at all if the LVS_ stuff was missing I tried t

Re: list view completely mangled in WINE

2004-08-03 Thread Robert Shearman
Dimitrie O. Paun wrote: On Tue, Aug 03, 2004 at 01:42:28AM +0200, Filip Navara wrote: have inserted debug messages on all the places where the listview display mode can be changed and none of them appeared. After going once more through the whole code I found this. Obviously it seemed redunda

Re: list view completely mangled in WINE

2004-08-02 Thread Dimitrie O. Paun
On Tue, Aug 03, 2004 at 03:17:27AM +0200, Filip Navara wrote: > I did another test. I intserted a code into the ListView window > procedure to print a message every time the internal dwStyle member > doesn't match the one returned by GetWindowLong with GWL_STYLE. To my > little surprise they wer

Re: list view completely mangled in WINE

2004-08-02 Thread Filip Navara
Dimitrie O. Paun wrote: [snip] The problem is that WM_STYLECHANGED is sometimes sent, sometimes not, and it seems so much easier to just update it every time we come in so we can be sure we're using the latest value, as we should. It's redundant, I agree, but it's neglijable in terms of performance

Re: list view completely mangled in WINE

2004-08-02 Thread Filip Navara
Dimitrie O. Paun wrote: On Tue, Aug 03, 2004 at 01:42:28AM +0200, Filip Navara wrote: Unfortunetly I can't explain it, because I don't understand it myself. I In which case I must object to the patch :( It seems we're just hiding a problem in a very convoluted way, don't you think? Well, I agre

Re: list view completely mangled in WINE

2004-08-02 Thread Dimitrie O. Paun
On Tue, Aug 03, 2004 at 01:42:28AM +0200, Filip Navara wrote: > Unfortunetly I can't explain it, because I don't understand it myself. I In which case I must object to the patch :( It seems we're just hiding a problem in a very convoluted way, don't you think? > have inserted debug messages on

Re: list view completely mangled in WINE

2004-08-02 Thread Filip Navara
Dimitrie O. Paun wrote: Can you please explain why updating it is a problem? Yes, we may be doing more work than needed, but at most it should be a no-op. In fact, we used to call 'GetWindowLongW(hwnd, GWL_STYLE)' every time we needed to get to the dwStyle, so updating it in there should be OK.

Re: list view completely mangled in WINE

2004-08-02 Thread Dimitrie O. Paun
On Sat, Jul 31, 2004 at 05:52:21AM +0200, Filip Navara wrote: > Tobias Burnus wrote: > [snip] > > Can you try the attached patch please? > > Changelog: > - Don't update infoPtr->dwStyle in LISTVIEW_WindoProc. It's already > handled in LISTVIEW_StyleChanged and LISTVIEW_Create processing. > >

Re: list view completely mangled in WINE

2004-08-02 Thread Filip Navara
Tobias Burnus wrote: The patch improves the situation a lot! Even Save List works now! Thanks! Great! [snip] Now, I click on the scrollbar to scroll to the rightmost columns; while the header is correct, the list itself contains the FIRST columns not the columns which belong to the column headers

Re: list view completely mangled in WINE

2004-08-02 Thread Tobias Burnus
Hello, Filip Navara wrote: Can you try the attached patch please? The patch improves the situation a lot! Even Save List works now! Thanks! Before: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_wine.png Afterwards: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_wine2.png The

Re: list view completely mangled in WINE

2004-07-30 Thread Filip Navara
Tobias Burnus wrote: [snip] Can you try the attached patch please? Regards, Filip Changelog: - Don't update infoPtr->dwStyle in LISTVIEW_WindoProc. It's already handled in LISTVIEW_StyleChanged and LISTVIEW_Create processing. - Fix TOOLBAR_DrawMasked to correctly use image list mask. Index: comc

Re: list view completely mangled in WINE

2004-07-30 Thread Dimitrie O. Paun
On Fri, Jul 30, 2004 at 05:26:57PM +0200, Tobias Burnus wrote: > Hello, > > in Crystal Impact's Diamond the list view is completely mangled and only > barely recognizable as list view. Tobias, I'll try to look into it. I have been however immensely busy lately, so please remind me if I don't

Re: list view completely mangled in WINE

2004-07-30 Thread Uwe Bonnes
> "Tobias" == Tobias Burnus <[EMAIL PROTECTED]> writes: Tobias> Hello, in Crystal Impact's Diamond the list view is completely Tobias> mangled and only barely recognizable as list view. Tobias> Result in WINE: Tobias> http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_w

list view completely mangled in WINE

2004-07-30 Thread Tobias Burnus
Hello, in Crystal Impact's Diamond the list view is completely mangled and only barely recognizable as list view. Result in WINE: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_wine.png Result in Windows: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list.png I'd be really ple