Re: libwine: Fix some typos

2006-12-21 Thread Andrew Talbot
Alexandre Julliard wrote: > On any decent Unix the S_ISCHR etc. macros are defined by sys/stat.h, > so our defines are never used. > Right. I now see that Splint represents S_ISCHR() and the like as functions (despite containing a comment saying that "they're macros virtually everywhere"), so the

Re: libwine: Fix some typos

2006-12-21 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > I am getting "unrecognized identifier" messages when looking at > ntdll/directory.c where it calls the S_ISCHR() and S_ISDIR() macros, these > are caused by the identifiers like _S_IFMT in "wine/port.h" seemingly not > being defined. The only place, on m

Re: libwine: Fix some typos

2006-12-21 Thread Andrew Talbot
Alexandre Julliard wrote: > Andrew Talbot <[EMAIL PROTECTED]> writes: > >> I believe these identifiers are POSIX ones (from ), so they >> should not possess one leading underscore (unlike the similar ones in >> "msvcrt"). > > These defines are meant for Windows, where they do have underscores. >

Re: libwine: Fix some typos

2006-12-21 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > I believe these identifiers are POSIX ones (from ), so they should > not possess one leading underscore (unlike the similar ones in "msvcrt"). These defines are meant for Windows, where they do have underscores. -- Alexandre Julliard [EMAIL PROTECTED]