Re: kernel32: add a test for CreateFileA() (try 3)

2010-07-26 Thread Andrew Nguyen
On Tue, Jul 27, 2010 at 12:53 AM, Austin English wrote: > Addressing Nikolay and Dmitry's comments. > > Passed wtb: > https://testbot.winehq.org/JobDetails.pl?Key=3947 > > -- > -Austin > > > You forgot to attach the patch.

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread Dmitry Timoshkov
Austin English wrote: > +SetLastError(0xdeadbeef); > +hFile = CreateFileA("c:\\*.*", GENERIC_READ, FILE_SHARE_READ, NULL, > OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL); > +ok(GetLastError() == ERROR_INVALID_NAME || > +broken(GetLastError() == ERROR_FILE_NOT_FOUND), /* Win98

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread Austin English
On Sun, Jul 18, 2010 at 1:24 AM, Nikolay Sivov wrote: >  On 7/18/2010 10:17, Austin English wrote: >> >> Passed all the vm's on wtb. > > Hi, Austin. This looks strange: > >> + >> +    hFile = CreateFileA("c:\\*.*", >> GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL >> );

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread Austin English
On Sun, Jul 18, 2010 at 9:39 AM, James McKenzie wrote: > Austin English wrote: >> >> Passed all the vm's on wtb. >> >>   >> >> > > +    hFile = CreateFileA("c:\\*.*", > GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTR

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread James McKenzie
Austin English wrote: Passed all the vm's on wtb. +hFile = CreateFileA("c:\\*.*", GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL ); +ok(GetLastError() == ERROR_INVALID_NAME || br

Re: kernel32: add a test for CreateFileA()

2010-07-17 Thread Nikolay Sivov
On 7/18/2010 10:17, Austin English wrote: Passed all the vm's on wtb. Hi, Austin. This looks strange: + +hFile = CreateFileA("c:\\*.*", GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL ); +ok(GetLastError() == ERROR_INVALID_NAME || broken(GetLastError() ==