Re: kernel32: Reimplement GetLogicalDrives using the mountmgr

2012-07-23 Thread Alexandre Julliard
GOUJON Alexandre writes: > I may be mis-using it but on my (virtualized) Win7, QueryDosDevice > with a NULL argument returns 6651 chars. > I truncated the output to the first strings and here's the result : > > Z: > Global > D: > ACPI#PNP0C0A#0#{72631e54-78a4-11d0-bcf7-00aa00b7b32a} > PhysicalDri

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr

2012-07-23 Thread GOUJON Alexandre
On 07/23/2012 09:15 PM, Alexandre Julliard wrote: GOUJON Alexandre writes: On 07/23/2012 03:03 PM, Alexandre Julliard wrote: That's very inefficient. There are better way of enumerating drives, check for instance QueryDosDevice. I'm not sure QueryDosDevice is more efficient : + with NULL dev

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr

2012-07-23 Thread Alexandre Julliard
GOUJON Alexandre writes: > On 07/23/2012 03:03 PM, Alexandre Julliard wrote: >> That's very inefficient. There are better way of enumerating drives, >> check for instance QueryDosDevice. > I'm not sure QueryDosDevice is more efficient : > + with NULL device name, it returns every MS-DOS device wh

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr

2012-07-23 Thread GOUJON Alexandre
On 07/23/2012 03:03 PM, Alexandre Julliard wrote: That's very inefficient. There are better way of enumerating drives, check for instance QueryDosDevice. I'm not sure QueryDosDevice is more efficient : + with NULL device name, it returns every MS-DOS device which is not what we want + if we ca

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr

2012-07-23 Thread Alexandre Julliard
Alexandre Goujon writes: > Previous approach was patch #88280 > --- > dlls/kernel32/volume.c | 18 +++--- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 8377e41..57453bb 100644 > --- a/dlls/kernel32/volume