I'll look into that case a bit this weekend if I can get the chance, I have
a busy schedule right now. My original patch did a series of renames
(though it had some other issues):
http://www.winehq.org/pipermail/wine-patches/2007-February/036394.html
However, talking with Felix Nawothnig on wine-
Kudos for your persistance. I hope this makes it in soon.
I see two remaining problems:
+/*
+ * This case should never occur, we've already checked
permissions earlier
+ * and we are holding the file handle open.
+ */
+ERR("Replacement file may not be del
On 3/19/07, Erich Hoover <[EMAIL PROTECTED]> wrote:
I still have not received any comments on the revised version of the
attached patch. I would appreciate any suggestions. Should I maybe
re-submit this patch?
Yes. The policy is to wait a week and if its not made it in to git
then resubmit.
hq.com/site/sending_patches.
Thanks!
Erich Hoover
[EMAIL PROTECTED]
-- Forwarded message --
From: Erich Hoover <[EMAIL PROTECTED]>
Date: Mar 3, 2007 2:37 PM
Subject: kernel32: Implement ReplaceFileA/ReplaceFileW (revised)
To: [EMAIL PROTECTED]
Real Name:
Erich Hoover
Request for comments, as per http://www.winehq.com/site/sending_patches.
Thanks!
Erich Hoover
[EMAIL PROTECTED]
-- Forwarded message --
From: Erich Hoover <[EMAIL PROTECTED]>
Date: Mar 3, 2007 2:37 PM
Subject: kernel32: Implement ReplaceFileA/ReplaceFileW (revised)
To:
Erich Hoover wrote:
I see your point. However, since the function you are implementing is in
kernel32 anyway you could abstract it away and make both functions
(CopyFile and ReplaceFile) call some internal function. That way you
would get rid of the locking completly which is argueably somewhat u
I see your point. However, since the function you are implementing is in
kernel32 anyway you could abstract it away and make both functions
(CopyFile and ReplaceFile) call some internal function. That way you
would get rid of the locking completly which is argueably somewhat ugly.
On closer inspe
Erich Hoover wrote:
The "right" way would probably to do the copying yourself by
read/write.. but I dunno.
Except that it would ignore the permissions issues that have already
been coded into the copy routines (and any updates that may eventually
No, CreateFile (and friends) does the permission
Oops, I must have hit the wrong reply button.
The "right" way would probably to do the copying yourself by
read/write.. but I dunno.
Except that it would ignore the permissions issues that have already
been coded into the copy routines (and any updates that may eventually
No, CreateFile (and f
(CC-ing wine-devel again)
Erich Hoover wrote:
The "right" way would probably to do the copying yourself by
read/write.. but I dunno.
Except that it would ignore the permissions issues that have already
been coded into the copy routines (and any updates that may eventually
No, CreateFile (and
Is the attached more like what you're looking for?
Erich Hoover
[EMAIL PROTECTED]
On 2/26/07, Felix Nawothnig <[EMAIL PROTECTED]> wrote:
Erich Hoover wrote:
> I assume you're referring to the file existence check and file delete,
> followed by the actual copy and move. I implemented these che
Erich Hoover wrote:
Is the attached more like what you're looking for?
I did some investigation and... actually I'm looking for an equivalent
to the linux splice syscall. Win32 is the most braindead API ever. Duh.
The "right" way would probably to do the copying yourself by
read/write.. but
; (Bug #7544). Also provides conformance test code to ensure proper
> functionality.
> Changelog:
> kernel32: Implement ReplaceFileA/ReplaceFileW
Your patch seems to introduce lots of race cons. It's possible these
exist on Win32 too but can't we avoid them?
Erich Hoover wrote:
I assume you're referring to the file existence check and file delete,
followed by the actual copy and move. I implemented these checks in
this manner in order to provide error codes consistent with the
documentation. I am not incredibly familiar with the Wine internals,
Erich Hoover wrote:
Real Name:
Erich Hoover
Description:
Implements the functions ReplaceFileA and ReplaceFileW in kernel32
(Bug #7544). Also provides conformance test code to ensure proper
functionality.
Changelog:
kernel32: Implement ReplaceFileA/ReplaceFileW
Your patch seems
15 matches
Mail list logo
