Re: kernel32: Enhance EndUpdateResource

2010-07-20 Thread Alexandre Julliard
Andrey Turkin writes: > Fixes bugs 12017 and 22812 > --- > dlls/kernel32/resource.c | 113 +++ > dlls/kernel32/tests/resource.c | 307 > +++- > 2 files changed, 326 insertions(+), 94 deletions(-) It breaks the tests: ../../../tools/runte

Re: kernel32: Enhance EndUpdateResource

2010-07-18 Thread Andrey Turkin
On Sunday 18 July 2010 00:26:36 Henri Verbeet wrote: > On 17 July 2010 09:06, Andrey Turkin wrote: > > +if (nt->OptionalHeader.FileAlignment <= 0) > > I can't comment much on the changes themselves, but FileAlignment is > unsigned, so can't be < 0. Original function has this check just befor

Re: kernel32: Enhance EndUpdateResource

2010-07-17 Thread Henri Verbeet
On 17 July 2010 09:06, Andrey Turkin wrote: > +if (nt->OptionalHeader.FileAlignment <= 0) I can't comment much on the changes themselves, but FileAlignment is unsigned, so can't be < 0.

Re: kernel32: Enhance EndUpdateResource

2010-07-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3105 Your paranoid android.