Alex Henrie writes:
> Hello,
>
> This patch was marked committed yesterday--thank you for accepting
> it!--but it still isn't showing up in Git. Maybe it was accidentally
> skipped? It needs to be committed before I can submit the UTF-7
> implementation I wrote that builds on it.
It wasn't actua
Hello,
This patch was marked committed yesterday--thank you for accepting
it!--but it still isn't showing up in Git. Maybe it was accidentally
skipped? It needs to be committed before I can submit the UTF-7
implementation I wrote that builds on it.
-Alex
2012/5/10 Juan Lang :
> Hi Alex,
> first, thanks for taking the time to respond to feedback. Showing
> responsiveness helps a great deal.
You're welcome :-)
> These helpers don't really gain you anything here, there's really not
> enough code to be worth using helpers. Please just copy/paste th
Hi Alex,
first, thanks for taking the time to respond to feedback. Showing
responsiveness helps a great deal.
Next, on your patch: I'm trying to help you get this committed, so
this is meant to be constructive feedback.
+static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR
2012/5/10 Nikolay Sivov :
>> Which file should I have used?
>
> codepage.c, you could search all test files for a thing you're trying to
> add.
Okay, I've moved the tests to codepage.c in try 4. Thanks for the tip,
I'll keep that in mind from now on.
> Nothing really changed in try3, test helpers
On 5/10/2012 07:38, Alex Henrie wrote:
2012/5/9 Nikolay Sivov:
Does any application depend on that?
Probably. Better safe than sorry, and Wine's current behavior
definitely doesn't match what MSDN says nor what Windows actually
does.
dlls/kernel32/locale.c | 38 ++---
d
2012/5/9 Nikolay Sivov :
> Does any application depend on that?
Probably. Better safe than sorry, and Wine's current behavior
definitely doesn't match what MSDN says nor what Windows actually
does.
>> dlls/kernel32/locale.c | 38 ++---
>> dlls/kernel32/tests/locale.c | 94
>
On 5/10/2012 00:52, Alex Henrie wrote:
This patch was a lot harder to figure out than I thought it was going to be.
The MSDN documentation of most of these behaviors can be found at
http://msdn.microsoft.com/en-us/library/windows/desktop/dd319072(v=vs.85).aspx
Does any application depend on tha
