Alex Henrie writes:
> Try 5 adds two tests for the case where srclen < -1 and passes them both.
You are still overflowing the source.
You need to spend more time on this. You also need to split the patch,
and write some sort of table-driven tests so you can test a lot more
cases, the ones you h
Alex Henrie writes:
> +do
> +{
> +if (src[source_index] == 0 && srclen == -1)
> +{
> +if (dry_run) dest_index++; else if (write_to_w_string(dst,
> dstlen, &dest_index, 0)) return -1;
> +/* when srclen=-1, terminate at the first null character found
Correction: I meant to write that try 4 exits the loop slightly faster when
ending a base64 sequence, it has nothing to do with escaped plus signs
which are handled a few lines earlier.
-Alex
Alex Henrie writes:
> Fixes bug 27388.
>
> This patch has been in the queue since May 21. I'm open to feedback.
It should all be in kernel32, not in libwine. Also you must do it
without memory allocations. You'd also want more tests for the overflow
cases, in particular for partial sequences.
-
Alex Henrie writes:
> 2012/5/8 Alexandre Julliard :
>> That code is hopelessly ugly, and broken in various ways. You are
>> probably better off starting from scratch.
>
> Okay. Could we use the POSIX iconv functions? Why doesn't Wine use
> iconv for UTF-8 already?
UTF-8 is trivial, using iconv w
2012/5/8 Alexandre Julliard :
> That code is hopelessly ugly, and broken in various ways. You are
> probably better off starting from scratch.
Okay. Could we use the POSIX iconv functions? Why doesn't Wine use
iconv for UTF-8 already?
-Alex
Alex Henrie writes:
> Hi all,
>
> Could I get some feedback on
> http://source.winehq.org/patches/data/85898 ? It was marked "Rejected"
> a week ago without explanation.
>
> Most of the code was authored by Katayama Hirofumi, whose patches have
> been accepted into Wine before. He gave permission
On 8 May 2012 12:50, Alex Henrie wrote:
> 2012/5/7 Ben Klein :
>> Without being a regular contributor, here are a few tips from a cursory
>> glance:
>> 1) Whitespace change on at least one line
>
> The only change to whitespace I made was:
>
> - if( flags)
> + if (flags)
>
> I don't
2012/5/7 Ben Klein :
> Without being a regular contributor, here are a few tips from a cursory
> glance:
> 1) Whitespace change on at least one line
The only change to whitespace I made was:
- if( flags)
+ if (flags)
I don't think this is a big deal.
> 2) Why the change from ERRO
On 8 May 2012 11:21, Alex Henrie wrote:
> Hi all,
>
> Could I get some feedback on
> http://source.winehq.org/patches/data/85898 ? It was marked "Rejected"
> a week ago without explanation.
Without being a regular contributor, here are a few tips from a cursory glance:
1) Whitespace change on at
Hi all,
Could I get some feedback on
http://source.winehq.org/patches/data/85898 ? It was marked "Rejected"
a week ago without explanation.
Most of the code was authored by Katayama Hirofumi, whose patches have
been accepted into Wine before. He gave permission to use his code
under the LGPL at h
11 matches
Mail list logo
