Re: kernel32/tests: initial tests for cdrom.c

2012-02-18 Thread Stefan Dösinger
Am Freitag, 17. Februar 2012, 14:45:37 schrieb Joerg-Cyril.Hoehle@t- systems.com: > Francois Gouget asked: > Some tests combinations. I believe Dan's tests want a DVD, whereas > mcicda expects audio CD-ROMs. Either you play disk jockey while > running the tests, or some tests will be skipped. Or

Re: kernel32/tests: initial tests for cdrom.c

2012-02-17 Thread Joerg-Cyril . Hoehle
Francois Gouget asked: >Are there tests that are impossible if there is a CD in the drive? Some tests combinations. I believe Dan's tests want a DVD, whereas mcicda expects audio CD-ROMs. Either you play disk jockey while running the tests, or some tests will be skipped. Note that mcicda will

Re: kernel32/tests: initial tests for cdrom.c

2012-02-16 Thread Francois Gouget
On Fri, 10 Feb 2012, joerg-cyril.hoe...@t-systems.com wrote: > Dan Kegel wrote: > >These require a DVD in the drive, so they are skipped without > >WINETEST_INTERACTIVE=1. > I don't see the causality. Presumably the tests require no human intervention. > > winmm/tests/mcicda also skips tests if n

Re: [PATCH 4/7] kernel32/tests: initial tests for cdrom.c (try 2)

2012-02-10 Thread Charles Davis
On Feb 10, 2012, at 1:30 PM, Dan Kegel wrote: > +START_TEST(cdrom) > +{ [...] > +/* GENERIC_WRITE because without it, passthrough doesn't work on win7 */ But with it, you can't open the device at all on Mac. As I explained on bug 29669, the device file only has 0440 access. Chip

kernel32/tests: initial tests for cdrom.c

2012-02-10 Thread Joerg-Cyril . Hoehle
Dan Kegel wrote: >These require a DVD in the drive, so they are skipped without >WINETEST_INTERACTIVE=1. I don't see the causality. Presumably the tests require no human intervention. winmm/tests/mcicda also skips tests if no CD-ROM is in the bay. However, even a regular winetest.exe run *will* r