Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)

2011-02-08 Thread Janne Hakonen
This test is safe, but it depends on the caller setting handle to some value other than INVALID_HANDLE_VALUE. I think it might be safer to have NotifyAddrChange set the handle value instead, and to mark the test todo_wine. I'm worried that some other app might assume that the call to NotifyAddrC

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)

2011-02-08 Thread Juan Lang
Hi Janne, +handle = NULL; +ZeroMemory(&overlapped, sizeof(overlapped)); +overlapped.hEvent = CreateEvent(NULL, FALSE, FALSE, NULL); +ret = gNotifyAddrChange(&handle, &overlapped); +ok(ret == ERROR_IO_PENDING, "NotifyAddrChange returned %d, expected ERROR_IO_PENDING\n", ret); +

RE: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases.

2011-02-07 Thread Janne Hakonen
> in todo_wine blocks only ok() calls should be made. > So consider splitting them down to "todo_wine ok(..." for each. Ah thank you, I will change them. > > -CancelIPChangeNotify > > CreateProxyArpEntry > > DeleteIPAddress > > DeleteProxyArpEntry > > EnableRouter > > FlushIpNetTable > >

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases.

2011-02-07 Thread André Hentschel
Hi, in todo_wine blocks only ok() calls should be made. So consider splitting them down to "todo_wine ok(..." for each. > -CancelIPChangeNotify > CreateProxyArpEntry > DeleteIPAddress > DeleteProxyArpEntry > EnableRouter > FlushIpNetTable > GetAdapterIndex > -NotifyAddrChange > -NotifyRouteC