Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack() (try 7)

2013-09-16 Thread Ralf Habacker
Am 10.09.2013 11:44, schrieb Ralf Habacker: > > - remove misleading comment Just for the record: http://msdn.microsoft.com/en-us/library/windows/desktop/aa365804%28v=vs.85%29.aspx do not mention any error code, which could be tested If the function succeeds, it returns ERROR_SUCCESS. If the funct

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack() (try 6)

2013-09-05 Thread Alexandre Julliard
Ralf Habacker writes: > +/** > + * test api function AllocateAndGetTcpExTableFromStack() > + * > + * Only specific tests required because the function is based > + * on build_tcp_table() which is covered by test_GetExtendedTcpTabl

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack()

2013-09-04 Thread Bruno Jesus
On Wed, Sep 4, 2013 at 8:02 AM, Ralf Habacker wrote: > > - added test case (update) > > Signed-off-by: Ralf Habacker > --- > dlls/iphlpapi/iphlpapi.spec|1 + > dlls/iphlpapi/ipstats.c| 33 + > dlls/iphlpapi/tests/iphlpapi.c | 32 +++

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack()

2013-09-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1995 Your paranoid andr

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-31 Thread Bruno Jesus
On Sat, Aug 31, 2013 at 9:16 AM, Ralf Habacker wrote: > new > - add doc for family parameter > - add doc for additional return code > - sorting in c file fixed > > Signed-off-by: Ralf Habacker I guess the patch was marked as pending because you didn't add any tests. You are also missing the (try

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-29 Thread Ralf Habacker
On 28.08.2013 12:54, Hans Leidekker wrote: On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 36ba13f..1eed5ae 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -6,6 +6,7 @@ @ stdcall

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 14:49 +0200, Ralf Habacker wrote: > >> diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h > >> index bf5bb92..efdb1cc 100644 > >> --- a/dlls/iphlpapi/ipstats.h > >> +++ b/dlls/iphlpapi/ipstats.h > >> @@ -33,6 +33,7 @@ > >> DWORD getInterfaceStatsByName(const char

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote: > diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec > index 36ba13f..1eed5ae 100644 > --- a/dlls/iphlpapi/iphlpapi.spec > +++ b/dlls/iphlpapi/iphlpapi.spec > @@ -6,6 +6,7 @@ > @ stdcall AllocateAndGetIpForwardTableFromSta

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 11:41 +0200, Ralf Habacker wrote: > diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec > index 36ba13f..cad2ca9 100644 > --- a/dlls/iphlpapi/iphlpapi.spec > +++ b/dlls/iphlpapi/iphlpapi.spec > @@ -6,6 +6,7 @@ > @ stdcall AllocateAndGetIpForwardTableFromSta

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Nikolay Sivov
On 8/28/2013 13:41, Ralf Habacker wrote: Signed-off-by: Ralf Habacker --- dlls/iphlpapi/iphlpapi.spec |1 + dlls/iphlpapi/ipstats.c | 26 ++ dlls/iphlpapi/ipstats.h |1 + include/tcpmib.h|3 +++ 4 Dateien geändert, 31 Zeilen hinzugefügt