Re: Should include files be bug for bug compatible?

2010-07-07 Thread Alexandre Julliard
Dylan Smith writes: > In richedit.h CHARFORMAT2[AW] is padded differently on the Windows > PSDK depending on whether it is included for a c or c++ source file. > > Should the include file be fixed, or does bug for bug compatibility > mean that a correct CHARFORMAT2 structure should be declared in

Should include files be bug for bug compatible?

2010-07-06 Thread Dylan Smith
In richedit.h CHARFORMAT2[AW] is padded differently on the Windows PSDK depending on whether it is included for a c or c++ source file. Should the include file be fixed, or does bug for bug compatibility mean that a correct CHARFORMAT2 structure should be declared in a private include file? I tri

Re: "typos" on some include files

2007-10-24 Thread Marcos Gutiérrez Batz
Oh God! Sorry about that! Dmitry Timoshkov wrote: "Marcos Gutiérrez Batz" <[EMAIL PROTECTED]> wrote: +HRESULT WINAPI HRESULT OleLoadPictureFile( + VARIANT varFileName, + LPDISPATCH *lplpdispPicture ) HRESULT is duplicated. $ diff -up /usr/src/wine/dlls/oleaut32/stubs.c stubs.c ---

Re: "typos" on some include files

2007-10-24 Thread Marcos Gutiérrez Batz
Added OleLoadPictureFile stub. Dmitry Timoshkov wrote: "Marcos Gutiérrez Batz" <[EMAIL PROTECTED]> wrote: $ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def --- liboleaut32.def 2007-08-23 16:15:48.0 +0200 +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.0

Re: "typos" on some include files

2007-10-24 Thread Marcos Gutiérrez Batz
I'll try to find the correct files to add the stub and then send the patch for that! Dmitry Timoshkov wrote: > "Marcos Gutiérrez Batz" <[EMAIL PROTECTED]> wrote: > >> $ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def >> --- liboleaut32.def 2007-08-23 16:15:48.0 +0200 >> +++ /u

Re: "typos" on some include files

2007-10-24 Thread Marcos Gutiérrez Batz
I hope it to be OK now! Dmitry Timoshkov wrote: "Marcos Gutiérrez Batz" <[EMAIL PROTECTED]> wrote: Attached is the "patch" file (diff -up) regarding the bug: http://bugs.winehq.org/show_bug.cgi?format=multiple&id=10156 The patch is reversed, please change the source/dest, rediff and resend.

Re: "typos" on some include files

2007-10-24 Thread Dmitry Timoshkov
"Marcos Gutiérrez Batz" <[EMAIL PROTECTED]> wrote: > +HRESULT WINAPI HRESULT OleLoadPictureFile( > + VARIANT varFileName, > + LPDISPATCH *lplpdispPicture ) HRESULT is duplicated. -- Dmitry.

Re: "typos" on some include files

2007-10-24 Thread Dmitry Timoshkov
"Marcos Gutiérrez Batz" <[EMAIL PROTECTED]> wrote: > $ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def > --- liboleaut32.def 2007-08-23 16:15:48.0 +0200 > +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.0 +0200 > @@ -366,7 +366,6 @@ EXPORTS > [EMAIL PROTEC

Re: "typos" on some include files

2007-10-24 Thread Dmitry Timoshkov
"Marcos Gutiérrez Batz" <[EMAIL PROTECTED]> wrote: > Attached is the "patch" file (diff -up) regarding the bug: > > http://bugs.winehq.org/show_bug.cgi?format=multiple&id=10156 The patch is reversed, please change the source/dest, rediff and resend. -- Dmitry.

Re: Adding L"" defines to include files ?

2006-09-01 Thread Frank Richter
On 01.09.2006 09:43, Paul Vriens wrote: > I've seen several occurrences of these in our own include files, so one > should think there is no harm. You could look how e.g. the WC_* macros are defined in commctrl.h. -f.r.

Re: Adding L"" defines to include files ?

2006-09-01 Thread Paul Vriens
On Fri, 2006-09-01 at 10:06 +0200, Marcus Meissner wrote: > On Fri, Sep 01, 2006 at 09:43:40AM +0200, Paul Vriens wrote: > > Hi, > > > > I'm currently dealing with the DllRegister part of wintrust. One of it's > > include files (softpu

Re: Adding L"" defines to include files ?

2006-09-01 Thread Marcus Meissner
On Fri, Sep 01, 2006 at 09:43:40AM +0200, Paul Vriens wrote: > Hi, > > I'm currently dealing with the DllRegister part of wintrust. One of it's > include files (softpub.h) on Windows has: > > #define SP_POLICY_PROVIDER_DLL_NAME L"WINTRUST.DLL" &

Adding L"" defines to include files ?

2006-09-01 Thread Paul Vriens
Hi, I'm currently dealing with the DllRegister part of wintrust. One of it's include files (softpub.h) on Windows has: #define SP_POLICY_PROVIDER_DLL_NAME L"WINTRUST.DLL" #define SP_INIT_FUNCTIONL"SoftpubInitialize" #define SP_OBJTRUST_FUNCTION

Re: [LOSTWAGES] update the non-standard include files task (RESEND)

2005-01-20 Thread Rémi Assailly
Selon "Dimitrie O. Paun" <[EMAIL PROTECTED]>: > On Thu, Jan 20, 2005 at 02:58:22PM +0900, Mike McCormack wrote: > > > > So did you ;) Here's a merge of both. > > I don't do this on purpose, but you missed win.h again :) > Again, with feeling... > > -- > Dimi. > win.h still exists...

Re: [LOSTWAGES] update the non-standard include files task (RESEND)

2005-01-20 Thread Dimitrie O. Paun
On Thu, Jan 20, 2005 at 02:30:09PM +0100, Rémi Assailly wrote: > win.h still exists... My bad, I've misread this check-in: http://www.winehq.org/hypermail/wine-cvs/2005/01/0463.html -- Dimi.

Re: [LOSTWAGES] update the non-standard include files task

2005-01-19 Thread Dimitrie O. Paun
Actually, you missed a few things. ChangeLog A few non-standard include files are gone. -- Dimi. ? diffs Index: templates/en/janitorial.template === RCS file: /home/wine/lostwages/templates/en/janitorial.template,v retrieving

Re: NOTIFY_PRE and NOTIFY_POST definitions in include files

2005-01-13 Thread Juan Lang
Francois wrote: > So I would say the correct values are the ones in npapi.h and that > netspi.h should be moved to dlls/mpr which is the only place where it is > used. But this needs a bit more investigation. I agree. I would conjecture that netspi.h is old, and the declarations in it have been

Re: NOTIFY_PRE and NOTIFY_POST definitions in include files

2005-01-13 Thread Francois Gouget
On Thu, 13 Jan 2005, Paul Vriens wrote: Hi, just found the following: [EMAIL PROTECTED] include]$ grep -e NOTIFY_PRE -e NOTIFY_POST * netspi.h:#define NOTIFY_PRE 0x00 netspi.h:#define NOTIFY_POST 0x01 I don't find netspi.h in the Platform SDK. I also don't find any of the

NOTIFY_PRE and NOTIFY_POST definitions in include files

2005-01-13 Thread Paul Vriens
Hi, just found the following: [EMAIL PROTECTED] include]$ grep -e NOTIFY_PRE -e NOTIFY_POST * netspi.h:#define NOTIFY_PRE 0x00 netspi.h:#define NOTIFY_POST 0x01 npapi.h:#define NOTIFY_PRE 0x0001 npapi.h:#define NOTIFY_POST 0x0002 this doesn't look right although

include files

2003-11-21 Thread Martin Fuchs
[Ralf Juengling] > > What is the status of the include files in msvcrt? [Alexandre Julliard] > They should work just fine. Make sure you also import msvcrt if you > use the headers. [Ralf Juengling] > > So my solution to make it compile was to remove wine's > > &#x

Re: include files

2003-11-20 Thread Francois Gouget
On Thu, 20 Nov 2003, Alexandre Julliard wrote: > Ralf Juengling <[EMAIL PROTECTED]> writes: > > > Why doesn't it also add > > /whereever/include/wine/msvcrt ? > > Because not everybody wants to use msvcrt. Unless you need some > specific features of the Windows C run time, in a Winelib app you are

Re: include files

2003-11-20 Thread Alexandre Julliard
Ralf Juengling <[EMAIL PROTECTED]> writes: > So my solution to make it compile was to remove wine's > 'math.h'. That's why I would say the include files are > incomplete. How do other people deal with a case like the > one I described? By submitting

Re: include files

2003-11-20 Thread Ralf Juengling
f the Windows C run time, in a Winelib app you are > better off using the standard Unix C library. > > > What is the status of the include files in msvcrt? > > They should work just fine. Make sure you also import msvcrt if you > use the headers. This might be a bug: 

Re: include files

2003-11-20 Thread Ralf Juengling
atures of the Windows C run time, in a Winelib app you are > better off using the standard Unix C library. Yes, I need for instance things defined in msvcrt/io.h and msvcrt/dos.h. > > > What is the status of the include files in msvcrt? > > They should work just fine. M

Re: include files

2003-11-20 Thread Alexandre Julliard
brary. > What is the status of the include files in msvcrt? They should work just fine. Make sure you also import msvcrt if you use the headers. -- Alexandre Julliard [EMAIL PROTECTED]

include files

2003-11-19 Thread Ralf Juengling
A Makefile created by winemake & configure adds /whereever/include/wine/windows to the include paths. Why doesn't it also add /whereever/include/wine/msvcrt ? What is the status of the include files in msvcrt? Ralf -- Ralf Juengling <[EMAIL PROTECTED]>