Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Kai Tietz
2011/10/26 Dmitry Timoshkov : > Chris Robinson wrote: > >> For Wine it doesn't really matter, since we can't use C++. For mingw-w64, >> however, it could be a big problem if it's not properly typed as a long. >> Overloads and template types would silently use 'int' where it should be >> using >>

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Dmitry Timoshkov
Chris Robinson wrote: > For Wine it doesn't really matter, since we can't use C++. For mingw-w64, > however, it could be a big problem if it's not properly typed as a long. > Overloads and template types would silently use 'int' where it should be > using > 'long', and you wouldn't necessaril

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Chris Robinson
On Wednesday, October 26, 2011 12:35:28 PM Michael Stefaniuc wrote: > Chris Robinson wrote: > > imagine some C++ function overrides tripping up with the int/long > > difference. > If you use the Wine headers this should actually fix it as it brings the > numeric constants in line with the types as

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Michael Stefaniuc
Chris Robinson wrote: > On Wednesday, October 26, 2011 12:17:22 PM Michael Stefaniuc wrote: >> Hello Jacek! >> >> Jacek Caban wrote: >>> mingw-w64 project imports some of our headers, including most of d3d >>> headers. They would probably prefer to keep them with 'l' modifier since >>> that's the r

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Chris Robinson
On Wednesday, October 26, 2011 12:17:22 PM Michael Stefaniuc wrote: > Hello Jacek! > > Jacek Caban wrote: > > mingw-w64 project imports some of our headers, including most of d3d > > headers. They would probably prefer to keep them with 'l' modifier since > > that's the right thing to do. Given th

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Kai Tietz
2011/10/26 Michael Stefaniuc : > Hello Jacek! > > Jacek Caban wrote: >> On 10/26/11 00:30, Michael Stefaniuc wrote: >>> --- >>>   include/d3d9caps.h |  182 >>> ++-- >>>   1 files changed, 91 insertions(+), 91 deletions(-) >>> >>> diff --git a/include/

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Michael Stefaniuc
Hello Jacek! Jacek Caban wrote: > On 10/26/11 00:30, Michael Stefaniuc wrote: >> --- >> include/d3d9caps.h | 182 >> ++-- >> 1 files changed, 91 insertions(+), 91 deletions(-) >> >> diff --git a/include/d3d9caps.h b/include/d3d9caps.h >> index 8e

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Jacek Caban
Hi Michael, On 10/26/11 00:30, Michael Stefaniuc wrote: --- include/d3d9caps.h | 182 ++-- 1 files changed, 91 insertions(+), 91 deletions(-) diff --git a/include/d3d9caps.h b/include/d3d9caps.h index 8ed6598..64dba21 100644 --- a/include/d3d9