Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-22 Thread Alexandre Julliard
Max TenEyck Woodbury writes: >> No, the current implementation is correct, debug.h should be usable from >> Winelib apps where you don't have access to Wine configure checks. >> > Ahh. Should the list of compilers that support varadic macros be > updated? If you have a compiler that you have ver

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-22 Thread Max TenEyck Woodbury
On 07/22/2010 03:35 AM, Alexandre Julliard wrote: Max TenEyck Woodbury writes: Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on the use of an

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-22 Thread Alexandre Julliard
Max TenEyck Woodbury writes: > Also, the current implementation is imperfect. There should be a test > in 'configure' for the various kinds of variadic macro support and the > conditionals should be based on what configure finds, not on the use of > any particular compiler. No, the current imple

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-21 Thread Max TenEyck Woodbury
Please discard this series of patches. They will not work with compilers that do not support macros with variable numbers of arguments. While most modern compilers do provide variadic macros, some older compilers do not. To do this right a non-intuitive syntax would be required. (i.e. 'FIXME_ONCE