Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.

2011-09-18 Thread Francois Gouget
On Fri, 16 Sep 2011, Jacek Caban wrote: [...] > IEs older than 7 had WebBrowser control implemented in shdocvw.dll. We surely > don't want to run tests on anything older than IE6. IE6 results very little > value in this case, so I consider DLL presence check as a nice way of skipping > tests on too

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.

2011-09-16 Thread Jacek Caban
On 09/16/11 15:42, Francois Gouget wrote: On Fri, 16 Sep 2011, Jacek Caban wrote: [...] hres = CoCreateInstance(&CLSID_WebBrowser, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, &IID_IUnknown, (void**)unk); -ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser objec

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.

2011-09-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14328 Your paranoid android

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.

2011-09-16 Thread Francois Gouget
On Fri, 16 Sep 2011, Jacek Caban wrote: [...] > > hres = CoCreateInstance(&CLSID_WebBrowser, NULL, > > CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > > &IID_IUnknown, (void**)unk); > > -ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser object failed: > > %08x\n", hres); >

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.

2011-09-16 Thread Jacek Caban
On 09/16/11 15:25, Francois Gouget wrote: --- This fixes this test on the WNT4WSSP6 testbot machine. It also helps on my NT4 VM but one would not notice because there's no ieframes dll so WineTest does not even try to run this test! dlls/ieframe/tests/webbrowser.c |5 - 1 files chang