Rob Shearman gmail.com> writes:
Thanks very much for your comments Rob,
I've updated the patch here:
http://bugs.winehq.org/attachment.cgi?id=16397
Hopefully correct now?
But now got another problem with the test, i changed it a bit like here:
http://bugs.winehq.org/attachment.cgi?id=16430
This
2008/9/29 Louis. Lenders <[EMAIL PROTECTED]>:
> Rob Shearman gmail.com> writes:
>
> Hi Rob, i think i got the test ready now, i'll send it when the defenitions
> are
> in place in ctxtcall.idl. Now still strugling how to fix the bug.
>
> I fixed up the patch below, also by looking how things are
Rob Shearman gmail.com> writes:
Hi Rob, i think i got the test ready now, i'll send it when the defenitions are
in place in ctxtcall.idl. Now still strugling how to fix the bug.
I fixed up the patch below, also by looking how things are done in similar
places in wine-code. With patch appli
2008/9/28 Louis Lenders <[EMAIL PROTECTED]>:
>
>> > +//#include "ctxtcall.h"
>>
>> Please resend the patch adding the IDL file for this generated file
>> and get it in before sending this patch adding the tests.
>>
>
> Hi Rob, thanks very much for the comments. I'll do the above , but i have
> prob
2008/9/28 Louis Lenders <[EMAIL PROTECTED]>:
>
>> > +//#include "ctxtcall.h"
>>
>> Please resend the patch adding the IDL file for this generated file
>> and get it in before sending this patch adding the tests.
>>
>
> Hi Rob, thanks very much for the comments. I'll do the above , but i have
> prob
> > +//#include "ctxtcall.h"
>
> Please resend the patch adding the IDL file for this generated file
> and get it in before sending this patch adding the tests.
>
Hi Rob, thanks very much for the comments. I'll do the above , but i have
problems when I uncomment the above include, i get:
compo
2008/9/28 Louis. Lenders <[EMAIL PROTECTED]>:
> Rob Shearman gmail.com> writes:
>> 2008/9/15 Louis Lenders yahoo.co.uk>:
>> > Rob Shearman gmail.com> writes:
>> I suggest you write a test case that replicates what the
>> application does and either send it to wine-patches
>> with appropriate tod
Rob Shearman gmail.com> writes:
>
> 2008/9/15 Louis Lenders yahoo.co.uk>:
> > Rob Shearman gmail.com> writes:
> I suggest you write a test case that replicates what the
> application does and either send it to wine-patches
> with appropriate todo_wine's or attach it to the bug.
> > Well, it
Rob Shearman gmail.com> writes:
>
> That's not acceptable as that change will cause applications that do
> use the returned interface to either crash on a NULL pointer (if you
> set *ppv to NULL and return S_OK) or stack corruption (if you return a
> pointer to the wrong interface). You will b
