Crash happens in 7-zip when opening context help from help menu
On Sat, Jun 19, 2010 at 7:05 AM, Dmitry Timoshkov
wrote:
> Jaroslav Šmíd wrote:
>
>> Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html
>> sent by Dmitry Timoshkov contains bug resulting in wine crash due to
>>
Jaroslav Šmíd wrote:
> Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html
> sent by Dmitry Timoshkov contains bug resulting in wine crash due to
> possible null pointer dereference. Please, see bug report at
> http://bugs.winehq.org/show_bug.cgi?id=23247 for more information
Perhaps. I don't mind as long as it doesn't crash :-)
--
Jaroslav Šmíd
Hi Jaroslav,
-if (!*caption) caption = info->pCHMInfo->defTitle;
+if (!caption) caption = info->pCHMInfo->defTitle;
I suspect a better fix would be:
+if (!caption || !*caption) caption = info->pCHMInfo->defTitle;
That is, either a NULL caption or an empty one results in
info->pCHMInf
