Re: hhctrl: IDTB_XXX resource strings

2011-08-31 Thread Owen Rudge
So I propose the attached patch. I wouldn't object to that. If somebody wants to implement support for the Jump buttons in the future, they can always be re-added, although I would say that in such a circumstance, a resource file entry wouldn't be necessary anyway. -- Owen Rudge http://www.

Re: hhctrl: IDTB_XXX resource strings

2011-08-31 Thread Francois Gouget
On Mon, 22 Aug 2011, Owen Rudge wrote: [...] > > But from there it's not clear to me they whether they will be used or > > not. Did you specifically mean that only Jump1/2 would not be used or > > does that apply to the other IDTB_XXX strings too? > > I was referring specifically to Jump1/2 in thi

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Owen Rudge
I see the strings being added to the toolbar with LPWSTR szBuf = HH_LoadString(buttons[dwIndex].idCommand); ... buttons[dwIndex].iString = (DWORD)SendMessageW(hToolbar, TB_ADDSTRINGW, 0, (LPARAM)szBuf); But from there it's not clear to me they whether they will be used or not. Did y

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Francois Gouget
On Mon, 22 Aug 2011, Owen Rudge wrote: > > What's the difference between 'Jump1' and 'Jump2'? > > Both are, it appears, toolbar buttons that can be customised by the help file > developer and used to link to individual topics or URLs. The captions are > customisable. The strings "Jump1" and "Jump

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Owen Rudge
However a number of them make no sense at all and are a pain to translate. For instance: IDTB_NOTES "IDTB_NOTES" IDTB_BROWSE_FWD "IDTB_BROWSE_FWD" IDTB_BROWSE_BACK "IDT_BROWSE_BACK" With regards to these buttons, attempting to use those constants on Windows results in but

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Owen Rudge
What's the difference between 'Jump1' and 'Jump2'? Both are, it appears, toolbar buttons that can be customised by the help file developer and used to link to individual topics or URLs. The captions are customisable. The strings "Jump1" and "Jump2" themselves, as far as I can tell, should nev

hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Francois Gouget
The native hhctrl.ocx does not have any resrouce strings. My understanding is that we have them in Wine because we use them as tooltips for the toolbar items. That's good I guess. However a number of them make no sense at all and are a pain to translate. For instance: IDTB_NOTES "ID