Re: gdiplus: implement GdipTransformPoints

2009-05-19 Thread Alexandre Julliard
Vincent Povirk writes: > It's odd, but it seems like the simplest way to write this. > > I've tried what I think was your suggestion, and that's attached. I > don't think it's an improvement. You should short-circuit the src_space == dst_space case, that would simplify things a lot. Then you can

Re: gdiplus: implement GdipTransformPoints

2009-05-18 Thread Nikolay Sivov
Vincent Povirk wrote: It's odd, but it seems like the simplest way to write this. I've tried what I think was your suggestion, and that's attached. I don't think it's an improvement. Vincent Povirk Could be a single switch maybe. Don't know, looks better for me. Comparisons were really ugl

Re: gdiplus: implement GdipTransformPoints

2009-05-18 Thread Vincent Povirk
ncent Povirk wrote: > > From 1de9b2291bf9a5617ca1e3b0cba5f1260889c259 Mon Sep 17 00:00:00 2001 > From: Vincent Povirk > Date: Mon, 23 Mar 2009 16:34:12 -0500 > Subject: [PATCH] gdiplus: implement GdipTransformPoints > > > It's a strange way to check enumeration with integer comparison, isn't i

Re: gdiplus: implement GdipTransformPoints

2009-05-18 Thread Nikolay Sivov
Vincent Povirk wrote: From 1de9b2291bf9a5617ca1e3b0cba5f1260889c259 Mon Sep 17 00:00:00 2001 From: Vincent Povirk Date: Mon, 23 Mar 2009 16:34:12 -0500 Subject: [PATCH] gdiplus: implement GdipTransformPoints It's a strange way to check enumeration with integer comparison, isn't i