Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
> * You can use git commit with the -a switch to modify the last commit. Whoops, I meant --amend. -a is something else.

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
>>Maybe, but builtin gdiplus has its own world transform and doesn't use >>the gdi32 one. That's what transform_and_round_points is for. > > True but you're still using the GDI32 DrawText to actually render the text. > transform_and_round_points is only doing what it says, transforming the > coor

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Michael Stefaniuc
Stephan Rose wrote: >> Just make two commits in Git, and format-patch will create two patch files. >> > > That makes sense but, one question there. Does this mean I'm going to > have to restore the file to it's original state, then add the one > change, commit, add the other change, then commit ag

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Stephan Rose
>(reply didn't go to list as I expected, grr..) > >> Naw, it should still work normally. I've done aligned & rotated text under >windows before with DrawTextW, you still pass the rect like you would if it >wasn't rotated and set the alignment flags. The world transform should take >care of getti

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
(reply didn't go to list as I expected, grr..) > Naw, it should still work normally. I've done aligned & rotated text under > windows before with DrawTextW, you still pass the rect like you would if it > wasn't rotated and set the alignment flags. The world transform should take > care of getti

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Stephan Rose
>Without doing any actual testing: > >The vertical alignment stuff looks right to me. > >Horizontal alignment is suspicious. If the world transform rotates the >text 90 degrees, DrawTextW can't be getting enough information to >center the text. Then again, I'm not sure if rotation works properly >w

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
Without doing any actual testing: The vertical alignment stuff looks right to me. Horizontal alignment is suspicious. If the world transform rotates the text 90 degrees, DrawTextW can't be getting enough information to center the text. Then again, I'm not sure if rotation works properly with Gdip

Re: gdiplus: add support for string alignment to GdipDrawString

2009-06-01 Thread Paul Vriens
Stephan Rose wrote: Adds support for aligning a string inside the given bounding rectangle for GdipDrawString. Both vertical and horizontal alignments implemented. Hi Stephan, No remarks about the real contents of the