Re: gdiplus: GdipDrawString should handle alignment in both directions in a similar way. Take 2.

2013-03-01 Thread Vincent Povirk
Sorry, I'm still not sure this is going to work. It seems to me that different lines will have to be offset by different amounts, and it's not clear to me how that's going to happen without the alignment logic in gdip_format_string. I'm also wondering if a change to the alignment logic in gdip_for

Re: gdiplus: GdipDrawString should handle alignment in both directions same way.

2013-02-28 Thread Vincent Povirk
> How are you handling the case where format is NULL? Never mind, I see what you're doing. But since the block where you now handle the horizontal alignment is inside an if (format->vertalign != StringAlignmentNear), this will break horizontal alignment when a vertical alignment is not set.

Re: gdiplus: GdipDrawString should handle alignment in both directions same way.

2013-02-28 Thread Vincent Povirk
> -if (format) halign = format->align; > -else halign = StringAlignmentNear; > - How are you handling the case where format is NULL?

Re: gdiplus: GdipDrawString is not supposed to use the layout rectangle for clipping. Take 2.

2012-04-25 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > There is a dedicated clip region in the graphics object. Please ignore that patch or mark it as rejected, the real problem has been fixed by 9b5b04c1c1a7b32dd3e1e453b6d739082c4ccede. -- Dmitry.

Re: gdiplus: GdipDrawString is not supposed to use the layout rectangle for clipping. Take 2.

2012-04-03 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I tried making a testcase for this, and I'm consistently seeing that > native only draws text that lies inside the rectangle if a positive > width or height are given. If I specify StringFormatFlagsNoClip then I > see a slight difference. Without the flag, the last line of

Re: gdiplus: GdipDrawString is not supposed to use the layout rectangle for clipping. Take 2.

2012-04-03 Thread Vincent Povirk
I tried making a testcase for this, and I'm consistently seeing that native only draws text that lies inside the rectangle if a positive width or height are given. If I specify StringFormatFlagsNoClip then I see a slight difference. Without the flag, the last line of text is clipped at the given he

Re: gdiplus: GdipDrawString

2009-06-01 Thread Austin English
On Mon, Jun 1, 2009 at 11:23 PM, Stephan Rose wrote: > On Mon, 2009-06-01 at 13:03 -0400, Stephan Rose wrote: >> >I don't know why gdiplus does its own linebreaks. I haven't really >> >done any work in that area. >> > >> >If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no >> >e

Re: gdiplus: GdipDrawString

2009-06-01 Thread Stephan Rose
On Mon, 2009-06-01 at 13:03 -0400, Stephan Rose wrote: > >I don't know why gdiplus does its own linebreaks. I haven't really > >done any work in that area. > > > >If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no > >equivalent flag for DrawText. That probably means you can't pa

Re: gdiplus: GdipDrawString

2009-06-01 Thread Stephan Rose
>I don't know why gdiplus does its own linebreaks. I haven't really >done any work in that area. > >If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no >equivalent flag for DrawText. That probably means you can't pass it >off to DrawText. > >Since they'll probably have to be done

Re: gdiplus: GdipDrawString

2009-06-01 Thread Vincent Povirk
I don't know why gdiplus does its own linebreaks. I haven't really done any work in that area. If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no equivalent flag for DrawText. That probably means you can't pass it off to DrawText. Since they'll probably have to be done differe

gdiplus: GdipDrawString

2009-06-01 Thread Stephan Rose
Ok was playing a bit with DrawString on sunday trying to get string alignments to work. I've got horizontal alignments working by simply setting drawcoord.right which currently is left uninitialized and then passing DT_CENTER and DT_RIGHT as needed to DrawTextW. So far, that worked. However, I