Re: gdiplus: Create a GDI brush only when needed.

2012-02-29 Thread Vincent Povirk
Looks better. Maybe create_gdi_logbrush should fall back to creating a solid brush, so that pens with weird brushes set will do something vaguely sensible. Eventually, we will want to use a different implementation of pens that does not involve gdi32 in those cases. On Wed, Feb 29, 2012 at 2:29 A

Re: gdiplus: Create a GDI brush only when needed.

2012-02-28 Thread Dmitry Timoshkov
te: Wed, 29 Feb 2012 16:24:45 +0800 Subject: gdiplus: Create a GDI brush only when needed. Take 2. To: wine-patc...@winehq.org Content-Type: text/plain; charset=US-ASCII This patch fixes the problem reported in the bug 29894. --- dlls/gdiplus/brush.c | 150 +++

Re: gdiplus: Create a GDI brush only when needed.

2012-02-15 Thread Vincent Povirk
The right solution is to remove the gdibrush and logbrush fields from GpBrush, and generate the HBRUSH as needed in brush_fill_path. Note that brush_fill_path will only be called for solid and hatch brushes (those for which brush_can_fill_path returns true), so we don't need the code to create a gd

Re: gdiplus: Create a GDI brush only when needed.

2012-02-15 Thread Vincent Povirk
This won't work. We create gdi32 brushes for hatch brushes based on temporary bitmaps that won't exist at the time brush_fill_path is called. On Wed, Feb 15, 2012 at 2:44 AM, Dmitry Timoshkov wrote: > This patch fixes the problem reported in the bug 29894. > --- >  dlls/gdiplus/brush.c