Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Nikolay Sivov
Andrew Eikum wrote: Nikolay Sivov wrote: Exactly, you should patch code too, not only tests. In this particular case it's better to check count first and return InvalidParameter and check for GdipAlloc result and return OutOfMemory if it's NULL. Okay, excellent. I'll make the patch for GdipDr

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Andrew Eikum
Nikolay Sivov wrote: Andrew Eikum wrote: Nikolay Sivov wrote: Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the func

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Nikolay Sivov
Andrew Eikum wrote: Nikolay Sivov wrote: Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_Gdip

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Andrew Eikum
Nikolay Sivov wrote: Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right abo

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Nikolay Sivov
Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of th

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Paul Vriens
Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of the different input po

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Andrew Eikum
This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of the different input possibilities for corr

Re: gdiplus: Add test cases for GdipDrawCurve

2009-06-02 Thread Paul Vriens
Andrew Eikum wrote: Vincent Povirk wrote: +/* make a graphics object and pen object */ +status = GdipCreateFromHDC(hdc, &graphics); +expect(Ok, status); +ok(hdc != NULL, "Expected HDC to be initialized\n"); + +status = GdipCreateFromHDC(hdc, &graphics); +expect(Ok,

Re: gdiplus: Add test cases for GdipDrawCurve

2009-06-02 Thread Andrew Eikum
Vincent Povirk wrote: +/* make a graphics object and pen object */ +status = GdipCreateFromHDC(hdc, &graphics); +expect(Ok, status); +ok(hdc != NULL, "Expected HDC to be initialized\n"); + +status = GdipCreateFromHDC(hdc, &graphics); +expect(Ok, status); +ok(gra

Re: gdiplus: Add test cases for GdipDrawCurve

2009-06-02 Thread Vincent Povirk
+/* make a graphics object and pen object */ +status = GdipCreateFromHDC(hdc, &graphics); +expect(Ok, status); +ok(hdc != NULL, "Expected HDC to be initialized\n"); + +status = GdipCreateFromHDC(hdc, &graphics); +expect(Ok, status); +ok(graphics != NULL, "Expected