Re: gdi32: use HandleToULong inline function to convert handle to index instead of casting

2012-10-11 Thread Alexandre Julliard
Daniel Lehman writes: > I'll admit that the upper 32 bits being set was because of a quirk in > our C++ code, but similar values passed to Windows worked This would need some test cases. -- Alexandre Julliard julli...@winehq.org

RE: gdi32: use HandleToULong inline function to convert handle to index instead of casting

2012-10-11 Thread Daniel Lehman
> It can't, the code explicitly casts handle to unsigned before the > shift. It's cast to a 64-bit unsigned, so the upper 32 bits are kept for the shift One of the pointers passed in was: 0xff26a8 after the shift, it became: 0xff26a8 => 0x3fc9aa When assigned to the 32

Re: gdi32: use HandleToULong inline function to convert handle to index instead of casting

2012-10-10 Thread Dmitry Timoshkov
Daniel Lehman wrote: > 0x26a8 becomes 0xc9aa instead of just 0x9aa It can't, the code explicitly casts handle to unsigned before the shift. -- Dmitry.